After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751021 - Use symbolic icons for fullscreen toolbar
Use symbolic icons for fullscreen toolbar
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-15 22:01 UTC by Alexandre Franke
Modified: 2015-06-23 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use symbolic icons for fullscreen toolbar (5.08 KB, patch)
2015-06-15 22:01 UTC, Alexandre Franke
none Details | Review
Use symbolic icons for fullscreen toolbar (5.99 KB, patch)
2015-06-19 13:09 UTC, Alexandre Franke
none Details | Review
Use symbolic icons for fullscreen toolbar (10.05 KB, patch)
2015-06-19 13:10 UTC, Alexandre Franke
none Details | Review
Remove non-symbolic gallery icon (22.02 KB, patch)
2015-06-19 16:17 UTC, Alexandre Franke
none Details | Review

Description Alexandre Franke 2015-06-15 22:01:35 UTC
The headerbar uses symbolic icons now, but the migration has not been done for
fullscreen toolbar yet. This patch solves the issue.
Comment 1 Alexandre Franke 2015-06-15 22:01:38 UTC
Created attachment 305352 [details] [review]
Use symbolic icons for fullscreen toolbar
Comment 2 Alexandre Franke 2015-06-19 13:09:09 UTC
Created attachment 305697 [details] [review]
Use symbolic icons for fullscreen toolbar
Comment 3 Alexandre Franke 2015-06-19 13:10:42 UTC
Created attachment 305698 [details] [review]
Use symbolic icons for fullscreen toolbar
Comment 4 Alexandre Franke 2015-06-19 15:01:18 UTC
With the addition of the symbolic icon for the gallery, should I just remove the non-symbolic icon now?

Apart from this detail, I think the patch is ready now so you can review it. :-)
Comment 5 Alexandre Franke 2015-06-19 16:17:33 UTC
Created attachment 305708 [details] [review]
Remove non-symbolic gallery icon

It is now useless since we use the symbolic one
Comment 6 Alexandre Franke 2015-06-19 16:18:57 UTC
I went ahead and removed the non symbolic icon. Feel free to reject this patch if you think we should keep it around.
Comment 7 Felix Riemann 2015-06-22 19:57:19 UTC
Thanks!

I also symbolized the leave-fullscreen icon, you seem to have forgotten.
Well see if the new symbolized gallery icon is expressive enough, as it's not that clear that it's four images. But I tried symbolizing the previous icon by using Adwaita's generic image icon and that didn't look any better. ;)
---
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 8 Alexandre Franke 2015-06-23 07:12:44 UTC
(In reply to Felix Riemann from comment #7)
> I also symbolized the leave-fullscreen icon, you seem to have forgotten.

Ah! It's not that I forgot, I didn't seem to find it. I probably didn't look for it hard enough. ;-)

Thanks for the quick review.