After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 751003 - glimagesink: Windows are sharing their events
glimagesink: Windows are sharing their events
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-15 15:41 UTC by Sebastian Dröge (slomo)
Modified: 2015-06-23 14:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2015-06-15 15:41:00 UTC
env GST_GL_XINITTHREADS=1 gst-launch-1.0 videotestsrc ! glimagesink  videotestsrc ! glimagesink


This usually crashes, but when it doesn't both windows are handling the events from each other. Resize one of the windows and observe the video inside the other one to shrink too (but the window size stays the same).
Comment 1 Vineeth 2015-06-16 10:43:22 UTC
The windows sharing happens because of the below commit..

http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/gst-libs/gst/gl/x11/gstglwindow_x11.c?id=5697b6b89b4b2a15c45bd47be940a17f4412ea11


If we revert this the resize happens properly...
But this does not help in solving the crashes which is happening quite frequently..
Noticed that the crashes are happening even in quite old versions as well
Comment 2 Vineeth 2015-06-17 01:20:02 UTC
i just observed something weird..

The frequent crash happens only with mesa driver.
If i change my driver to NVidia the crash disappears.
 

With Nvidia driver
"OpenGL version string: 4.4.0 NVIDIA 331.113"
it doesnt crash at all

But with Mesa driver
"OpenGL version string: 3.0 Mesa 10.3.2"
it crashes very frequently.


PS: the event sharing issue does get fixed on reverting the above changes.
Comment 3 Matthew Waters (ystreet00) 2015-06-18 10:38:21 UTC
This whole scenario seems to be caused by a broken Mesa.  I just tried mesa master on my i965 card and everything works reverting the above commit.

Vineeth:
Are you running nouveau on a nvidia chip with Mesa 10.3.2?  If so what generation?
Comment 4 Vineeth 2015-06-18 21:30:49 UTC
Matthew:
yes i am running Nouveau display driver on nvidia chip.

did not get what do you mean by generation!
Comment 5 Matthew Waters (ystreet00) 2015-06-19 03:47:20 UTC
http://nouveau.freedesktop.org/wiki/CodeNames/ what nvXX where XX is a number.  Can be retrieved with lspci.

Also, Mesa 10.3 is at least a year old now.  You should consider upgrading, especially for nouveau usage.
Comment 6 Vineeth 2015-06-19 09:16:16 UTC
lspci gives
01:00.0 3D controller: NVIDIA Corporation GF117M [GeForce 610M/710M/820M / GT 620M/625M/630M/720M] (rev a1)

How to proceed about the window sharing issue?
is it ok to revert the change or will there be a better way to fix it?
Comment 7 Sebastian Dröge (slomo) 2015-06-22 10:41:42 UTC
So this is a mesa bug? Or... ?
Comment 8 Vineeth 2015-06-22 10:44:21 UTC
from my understanding, the crashes seem to be mesa bug.
But the window sharing is related to the above mentioned patch, as the same issue happens with nvidia driver as well
Comment 9 Sebastian Dröge (slomo) 2015-06-22 10:54:18 UTC
So that patch should be fixed then at least, and things be reported to the mesa people ;)

The problem with that patch is then that we now have the same X11 connection for all windows, but don't properly send events only to the window for which they are?
Comment 10 Matthew Waters (ystreet00) 2015-06-23 14:43:18 UTC
Patch should be reverted.  Mesa master is already fixed it seems.
Comment 11 Sebastian Dröge (slomo) 2015-06-23 14:47:18 UTC
Ok, let's do that then. Thanks!

commit cb01fbfc2743fefbaafcaab60f3f7e66de9d379c
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Jun 23 16:46:39 2015 +0200

    Revert "gl/window/x11: don't create our own X11 display"
    
    This reverts commit 5697b6b89b4b2a15c45bd47be940a17f4412ea11.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=751003