GNOME Bugzilla – Bug 750987
UI: Update the preferences dialog
Last modified: 2015-08-18 18:10:20 UTC
Update the look of the preferences dialog following the last HIG recommendations: https://developer.gnome.org/hig/stable/dialogs.html.en Remove deprecated widgets too.
Created attachment 305298 [details] [review] UI: Removed preferences dialog "Close" button Following the HIG recommendations, the "close" button is not required in the preferences dialog, instead, we are going to use a HeaderBar (with a close button) See
Created attachment 305299 [details] [review] UI: Preferences window, transient for main window See
I'm working on it, remains the GtkTable stuff...
Review of attachment 305298 [details] [review]: ++
Review of attachment 305299 [details] [review]: ++
A couple of things I noticed while testing this: • The dialogue title should be ‘Preferences’ rather than ‘Almanah Preferences’ — the ‘Almanah’ is redundant if it’s a modal dialogue. • The ‘New Key’ button opens Seahorse, but doesn’t open a window for creating a new key, so the user could easily get confused. • The dialogue is resizable so I can make it really tall and have lots of blank space at the bottom. It probably shouldn’t be resizable, but should perhaps be a bit wider by default. • In fact, perhaps the ‘New Key’ button should be on a new line, along with a bit of text explaining what the encryption key is used for — that it should be one of your keys, and that if you delete the key you will lose access to the diary forever. Or something like that.
(In reply to Philip Withnall from comment #6) > A couple of things I noticed while testing this: > • The dialogue title should be ‘Preferences’ rather than ‘Almanah > Preferences’ — the ‘Almanah’ is redundant if it’s a modal dialogue. Totally agree. > • The ‘New Key’ button opens Seahorse, but doesn’t open a window for > creating a new key, so the user could easily get confused. > • The dialogue is resizable so I can make it really tall and have lots of > blank space at the bottom. It probably shouldn’t be resizable, but should > perhaps be a bit wider by default. > • In fact, perhaps the ‘New Key’ button should be on a new line, along with > a bit of text explaining what the encryption key is used for — that it > should be one of your keys, and that if you delete the key you will lose > access to the diary forever. Or something like that. I'm thinking in a redefinition of the encryption interaction (https://bugzilla.gnome.org/show_bug.cgi?id=676829) Perhaps is not necessary to open Seahorse because is possible to create a new key with GPGMe. I'm going to update the 'New Key' button as you point, but we can continue the key/encryption/security discussion in 676829.
Review of attachment 305298 [details] [review]: Done.
Review of attachment 305299 [details] [review]: Done
Created attachment 309227 [details] [review] UI: Removed preferences dialog redundant title The "Almanah" word has been removed from the preferences dialog title.
Created attachment 309228 [details] [review] UI: Replaced deprecated GtkTable by GtkGrid
Review of attachment 309227 [details] [review]: Looks good to me.
Review of attachment 309228 [details] [review]: Looks good to me!
Thanks Philip for taking time to review the patches. Kudos for you.
Attachment 309227 [details] pushed as 8e9d351 - UI: Removed preferences dialog redundant title Attachment 309228 [details] pushed as 4ee15e5 - UI: Replaced deprecated GtkTable by GtkGrid