GNOME Bugzilla – Bug 750984
GdMainView: generic view model not found when rebuilding
Last modified: 2015-06-19 15:27:49 UTC
When rebuilding the main view after changing the view type, this critical error occurend: Gtk-CRITICAL **: gtk_tree_model_foreach: assertion 'GTK_IS_TREE_MODEL (model)' failed. This is caused when rebuilding the widget: the selection mode is applied before the model, causing the selection mode to have no model to work with.
Created attachment 305275 [details] [review] main-view: Apply model before selection This applies the model before the selection while rebuilding. This is necessary because otherwise the model of the generic view may not be set while applying the selection mode, causing critical errors.
Review of attachment 305275 [details] [review]: Looks good to me. Some nits (more like improvement ideas) as always :) * "main-view: Apply model before selection" -> "main-view: Mdel before selection mode" * "the selection" -> "applying the selection mode" * "critical errors" -> "critical errors on console"
Created attachment 305695 [details] [review] main-view: Model before selection mode This applies the model before applying the selection mode while rebuilding. This is necessary because otherwise the model of the generic view may not be set while applying the selection mode, causing critical errors on console.
Attachment 305695 [details] pushed as 241f3d5 - main-view: Model before selection mode