After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750934 - Wrapper: get_layer doesn't check for AccessibleRole window
Wrapper: get_layer doesn't check for AccessibleRole window
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Magdalen Berns (irc magpie)
java-atk-wrapper maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-14 12:47 UTC by Magdalen Berns (irc magpie)
Modified: 2015-06-28 15:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to address problem (1.31 KB, patch)
2015-06-14 12:53 UTC, Magdalen Berns (irc magpie) 		none Details | Review
patch to add check (901 bytes, patch)
2015-06-26 22:53 UTC, Magdalen Berns (irc magpie) 		committed Details | Review

Description Magdalen Berns (irc magpie) 2015-06-14 12:47:35 UTC 
The get_layer method is supposed to check the role of the accessible object and return an AtkLayer integer which corresponds with the appropriate layer for the role but a check for AccessibleRole.WINDOW is not there.
Comment 1 Magdalen Berns (irc magpie) 2015-06-14 12:53:07 UTC 
Created attachment 305230 [details] [review]
Patch to address problem
Comment 2 Magdalen Berns (irc magpie) 2015-06-24 21:39:55 UTC 
Actually this doesn't need to be resolved because atk_object_get_localised_name is part of the public API with no pointer: https://git.gnome.org/browse/atk/tree/atk/atkobject.h#n765
Comment 3 Magdalen Berns (irc magpie) 2015-06-24 21:41:17 UTC 
Oops sorry, too many windows open... I meant this for bug 740542. Reopening!
Comment 4 Magdalen Berns (irc magpie) 2015-06-26 22:53:04 UTC 
Created attachment 306193 [details] [review]
patch to add check
Comment 5 Magdalen Berns (irc magpie) 2015-06-28 15:52:54 UTC 
Review of attachment 306193 [details] [review]:

Committed to master