After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750892 - testfontchooserdialog.c requires pangoft2
testfontchooserdialog.c requires pangoft2
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.17.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-06-13 07:42 UTC by Juan R. Garcia Blanco
Modified: 2015-07-08 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix build on x11`less wayland platform (1.81 KB, patch)
2015-07-08 04:42 UTC, nick
none Details | Review
a proper v2 than previous and obsoleted v1 (2.17 KB, patch)
2015-07-08 10:59 UTC, nick
none Details | Review

Description Juan R. Garcia Blanco 2015-06-13 07:42:53 UTC
I have run into this problem when building for OS X, so I'm concerned this may be a OS X specific issue. Anyway, I think pangoft2 is missing in PANGO_PACKAGES.

E.g. pango_fc_font_map_set_config, which is used in testfontchooserdialog.c, is defined in pangofc-fontmap.c, which according to Makefile.am is only included in libpangoft2. libpango makes no references to libpangoft2.
Comment 1 Emmanuele Bassi (:ebassi) 2015-06-13 08:00:10 UTC
There's a bit of confusion.

The pango_fc_* is the fontconfig API, not the freetype2 one; neither are needed on MacOS.

The test should do a conditional check on Pango or on the platform.
Comment 2 nick 2015-07-08 04:42:39 UTC
Created attachment 307047 [details] [review]
fix build on x11`less wayland platform

i send this gtk-devel ML too.
Comment 3 nick 2015-07-08 10:59:23 UTC
Created attachment 307065 [details] [review]
a proper v2 than previous and obsoleted v1
Comment 4 nick 2015-07-08 11:03:31 UTC
notice: patches not OS X related