After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750888 - Fix return value error in _gtk_text_handle_set_direction
Fix return value error in _gtk_text_handle_set_direction
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.17.x
Other FreeBSD
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-06-13 05:45 UTC by Ting-Wei Lan
Modified: 2015-06-13 15:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix return value error in _gtk_text_handle_set_direction (819 bytes, patch)
2015-06-13 05:47 UTC, Ting-Wei Lan 		committed Details | Review
Fix 'void function should not return void expression' warning for clang (959 bytes, patch)
2015-06-13 05:50 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2015-06-13 05:45:26 UTC 
Please see the patch. This fixes error when compiling with clang.

gtktexthandle.c:839:3: error: void function '_gtk_text_handle_set_direction' should not return a value [-Wreturn-type]
Comment 1 Ting-Wei Lan 2015-06-13 05:47:53 UTC 
Created attachment 305187 [details] [review]
Fix return value error in _gtk_text_handle_set_direction
Comment 2 Ting-Wei Lan 2015-06-13 05:50:10 UTC 
Created attachment 305188 [details] [review]
Fix 'void function should not return void expression' warning for clang

This patch fixes another unrelated return error warning. I hope it can also be pushed.
Comment 3 Matthias Clasen 2015-06-13 13:50:15 UTC 
Review of attachment 305187 [details] [review]:

sure
Comment 4 Matthias Clasen 2015-06-13 13:50:33 UTC 
Review of attachment 305188 [details] [review]:

ok
Comment 5 Ting-Wei Lan 2015-06-13 15:04:41 UTC 
Attachment 305187 [details] pushed as d8657a8 - Fix return value error in _gtk_text_handle_set_direction
Attachment 305188 [details] pushed as 41b6993 - Fix 'void function should not return void expression' warning for clang