After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750788 - videofilters: Support for unsharp filter
videofilters: Support for unsharp filter
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-11 11:18 UTC by Sanjay NM
Modified: 2018-05-06 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videofilters: Added support for unsharp filter (8.50 KB, patch)
2015-06-11 11:26 UTC, Sanjay NM 		none Details | Review
Input and output images (52.10 KB, image/jpeg)
2015-06-11 11:27 UTC, Sanjay NM 		  Details

Description Sanjay NM 2015-06-11 11:18:59 UTC 
There is no support for unsharp filter which is used for enhancement
Comment 1 Sanjay NM 2015-06-11 11:26:24 UTC 
Created attachment 305068 [details] [review]
videofilters: Added support for unsharp filter

Added support for unsharp mask in convolution which is used for image and video enhancement. It is tested with below pipeline

gst-launch-1.0 filesrc location=pm.mp4 ! decodebin ! videoconvert ! unsharp ! videoconvert ! ximagesink
Comment 2 Sanjay NM 2015-06-11 11:27:19 UTC 
Created attachment 305069 [details]
Input and output images

Added input and output images
Comment 3 Sebastian Dröge (slomo) 2015-06-11 11:43:45 UTC 
Review of attachment 305068 [details] [review]:

Is this just a blur filter? The matrix looks like guassian blur or similar. Maybe name it like that then, and maybe also add some property to switch between different blur matrices.

::: gst/videofilters/gstunsharp.c
@@ +51,3 @@
+#define gst_video_unsharp_filter_parent_class parent_class
+G_DEFINE_TYPE (GstVideoUnsharpFilter, gst_video_unsharp_filter,
+    GST_TYPE_VIDEO_BASE_CONVOLVE_FILTER);

I would call the type GstVideoBaseConvolutionFilter, not Convolve
Comment 4 Tim-Philipp Müller 2015-06-11 11:56:45 UTC 
There's already a gaussianblur element in the gaudieffects plugin fwiw.
Comment 5 Tim-Philipp Müller 2016-04-11 16:44:17 UTC 
Sanjay, could you comment how this filter is different from the existing elements?
Comment 6 Vivia Nikolaidou 2018-05-06 12:17:30 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!