After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750764 - gst-rtsp-server: add missing apis to doc
gst-rtsp-server: add missing apis to doc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal minor
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-11 08:35 UTC by Hyunjun Ko
Modified: 2015-06-11 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
docs: add missing apis (1.84 KB, patch)
2015-06-11 08:43 UTC, Hyunjun Ko
committed Details | Review
rtsp-stream: add description for gst_rtsp_stream_request_aux_sender (969 bytes, patch)
2015-06-11 08:45 UTC, Hyunjun Ko
committed Details | Review
docs: add missing types (1.34 KB, patch)
2015-06-11 09:12 UTC, Hyunjun Ko
committed Details | Review
rtsp-client: move handle_sdp declaration to vmethod side (1.56 KB, patch)
2015-06-11 09:20 UTC, Hyunjun Ko
rejected Details | Review

Description Hyunjun Ko 2015-06-11 08:35:16 UTC
Some apis are missing in doc.
rtsp-media : gst_rtsp_media_set_latency / gst_rtsp_media_get_latency / gst_rtsp_media_handle_sdp
rtsp-media-factory : gst_rtsp_media_factory_set_latency / gst_rtsp_media_factory_get_latency / gst_rtsp_media_factory_get_media_gtype / gst_rtsp_media_factory_set_media_gtype
rtsp-stream : gst_rtsp_stream_set_pt_map / gst_rtsp_stream_request_aux_sender / gst_rtsp_stream_set_seqnum_offset / gst_rtsp_stream_get_current_seqnum  / gst_rtsp_stream_query_stop / gst_rtsp_stream_query_position
Comment 1 Hyunjun Ko 2015-06-11 08:36:42 UTC
(In reply to Hyunjun from comment #0)
> Some apis are missing in doc.
rtsp-media : 
- gst_rtsp_media_set_latency
- gst_rtsp_media_get_latency
- gst_rtsp_media_handle_sdp

rtsp-media-factory :
- gst_rtsp_media_factory_set_latency
- gst_rtsp_media_factory_get_latency
- gst_rtsp_media_factory_get_media_gtype
- gst_rtsp_media_factory_set_media_gtype

rtsp-stream :
- gst_rtsp_stream_set_pt_map
- gst_rtsp_stream_request_aux_sender
- gst_rtsp_stream_set_seqnum_offset
- gst_rtsp_stream_get_current_seqnum
- gst_rtsp_stream_query_stop
- gst_rtsp_stream_query_position
Comment 2 Hyunjun Ko 2015-06-11 08:43:24 UTC
Created attachment 305049 [details] [review]
docs: add missing apis

add missing apis
Comment 3 Hyunjun Ko 2015-06-11 08:45:56 UTC
Created attachment 305050 [details] [review]
rtsp-stream: add description for gst_rtsp_stream_request_aux_sender

That function is pushed in https://bugzilla.gnome.org/show_bug.cgi?id=747839
I missed function descriptions.
Comment 4 Hyunjun Ko 2015-06-11 09:12:08 UTC
Created attachment 305054 [details] [review]
docs: add missing types

docs: add missing types to gst-rtsp-server.types
Comment 5 Hyunjun Ko 2015-06-11 09:20:17 UTC
Created attachment 305055 [details] [review]
rtsp-client: move handle_sdp declaration to vmethod side

During this work, I found one minor problem.
handle_sdp is vmethod, not signal handler.
IMO, it needs to be moved.
Comment 6 Tim-Philipp Müller 2015-06-11 10:38:33 UTC
Comment on attachment 305055 [details] [review]
rtsp-client: move handle_sdp declaration to vmethod side

Can't do this, this breaks ABI compatibility.
Comment 7 Tim-Philipp Müller 2015-06-11 10:47:02 UTC
Thanks for the patches. I've pushed the other ones:

commit 2a3dd3d38fe51d4688dd0ac48e20d8d7e60b2630
Author: Hyunjun Ko <zzoon.ko@samsung.com>
Date:   Thu Jun 11 17:38:52 2015 +0900

    rtsp-stream: add description for gst_rtsp_stream_request_aux_sender
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750764

commit 93d37df0c3971b24c686a856540171287f6be754
Author: Hyunjun Ko <zzoon.ko@samsung.com>
Date:   Thu Jun 11 18:10:12 2015 +0900

    docs: add missing types
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750764

commit 8c1eb6fb4f509ee466d81a0e1f3233262c277403
Author: Hyunjun Ko <zzoon.ko@samsung.com>
Date:   Thu Jun 11 17:37:25 2015 +0900

    docs: add missing apis
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750764


(and added a 'Since: 1.6' to the function doc blurb).