After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750723 - shell command 'source' is not portable
shell command 'source' is not portable
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
1.20.x
Other FreeBSD
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-10 16:40 UTC by Ting-Wei Lan
Modified: 2015-10-23 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Use a dot instead of source command (953 bytes, patch)
2015-06-10 16:40 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2015-06-10 16:40:03 UTC
tests/unit/Makefile.am uses 'source' command to read the .la file. This can fail because not all shells support 'source' command. POSIX only defines the dot command, not 'source' command.
Comment 1 Ting-Wei Lan 2015-06-10 16:40:56 UTC
Created attachment 304997 [details] [review]
build: Use a dot instead of source command
Comment 2 Emmanuele Bassi (:ebassi) 2015-06-10 16:52:52 UTC
Review of attachment 304997 [details] [review]:

Looks good. Please, commit to the cogl-1.20 branch.
Comment 3 Ting-Wei Lan 2015-06-10 17:03:17 UTC
Attachment 304997 [details] pushed as c013165 - build: Use a dot instead of source command
Comment 4 Patrick Welche 2015-10-23 15:41:39 UTC
(In reply to Emmanuele Bassi (:ebassi) from comment #2)
> Review of attachment 304997 [details] [review] [review]:
> 
> Looks good. Please, commit to the cogl-1.20 branch.

Why not also apply to master? (It is correct afterall...)
Comment 5 Emmanuele Bassi (:ebassi) 2015-10-23 15:55:24 UTC
Because nothing uses master.
Comment 6 Patrick Welche 2015-10-23 16:04:23 UTC
Hmm... cogl-1.22 branch, doc/RELEASING

     $ git push origin master
     $ git push origin 1.7.0

So cogl-1.22 is what I would call the current head? (What of wip/cogl-2.0?)
Comment 7 Emmanuele Bassi (:ebassi) 2015-10-23 16:12:45 UTC
You should not be using Bugzilla as a forum.

(In reply to Patrick Welche from comment #6)
> Hmm... cogl-1.22 branch, doc/RELEASING
> 
>      $ git push origin master
>      $ git push origin 1.7.0
> 
> So cogl-1.22 is what I would call the current head?

Yes.

> (What of wip/cogl-2.0?)

You can safely ignore it.