GNOME Bugzilla – Bug 750721
tools: gst-play: Print artist/album/title tags
Last modified: 2018-11-03 11:38:06 UTC
Created attachment 304992 [details] [review] Patch file Print artist/album/title information for each track played.
Review of attachment 304992 [details] [review]: Makes sense to me, why is this rejected? Should probably print all tags from the tag messages though, not just these few. See gst-launch code for some code that prints arbitrary tags ::: tools/gst-play.c @@ +446,3 @@ + if (!play->printed_tags) { + gchar *str; + if (gst_tag_list_get_string (tags, GST_TAG_ARTIST, &str)) { You're leaking the strings here
It basically needs to be redone while keeping a streaming radio in mind. New tags might fly by because the bitrate changed marginally, or because we've moved to the next track. We shouldn't reprint all the things if the bitrate changes marginally, but we should detect that we've moved to the next track. Maybe remember title and artist and only print new information if these two change? Also, just spoke with Tim, he said he's also happy with just artist/album/title and not all the things - personally I also slightly prefer printing just these, but don't really have a strong preference :)
Note that the version of gst-play in GstPlayer has this feature already
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/194.