GNOME Bugzilla – Bug 750718
Improve documentation for deprecated properties
Last modified: 2015-06-11 10:46:53 UTC
I stumbled across a few deprecation warnings which did not point out a strategy to remedy the deprecation: GtkTreeView:rules-hint (deprecated since 3.14, no suggestion) The other instances I cam across admittedly are for widgets deprecated as a whole: GtkAlignment:top-padding -> - (?) GtkImageMenuItem:always-show-image -> - (3.10) GtkImageMenuItem:use-stock -> - (3.10) GtkMisc:xpad -> - (?) GtkTreeView:rules-hint -> - (3.14) The following two are especially annoying since there apparently there is nothing I can do to fix them - I don't deal with GtkSetting. GtkSettings:gtk-button-images -> - (?) GtkSettings:gtk-menu-images -> - (?)
(In reply to Simon Budig from comment #0) > I stumbled across a few deprecation warnings which did not point out a > strategy to remedy the deprecation: > > GtkTreeView:rules-hint (deprecated since 3.14, no suggestion) Yep, there's no replacement for this. It's entirely up to the theme to decide whether or not to have zebra striping — which is exactly like it was before, since themes were responsible to implement it anyway. See bug 733312 for the rationale of why this was a bad API. > The other instances I cam across admittedly are for widgets deprecated as a > whole: > > GtkAlignment:top-padding -> - (?) The whole GtkAlignment class is deprecated since 3.14, but properties should have separate deprecation notices. > GtkImageMenuItem:always-show-image -> - (3.10) > GtkImageMenuItem:use-stock -> - (3.10) Same for GtkImageMenuItem. > GtkMisc:xpad -> - (?) Same for GtkMisc. > The following two are especially annoying since there apparently there is > nothing I can do to fix them - I don't deal with GtkSetting. > > GtkSettings:gtk-button-images -> - (?) > GtkSettings:gtk-menu-images -> - (?) These are the result of using the stock icons API in GtkButton, GtkToolItem, or GtkMenuItem, or using deprecated classes like GtkImageMenuItem.
Created attachment 304987 [details] [review] docs: Add deprecation notices for GtkAlignment properties We want people to port their code away from deprecated classes, and this helps finding a replacement.
Created attachment 304988 [details] [review] docs: Improve deprecation notices for GtkImageMenuItem properties Should help porting code away from the deprecated GtkImageMenuItem class.
Created attachment 304989 [details] [review] docs: Improve deprecation notice for rules-hint property Specify that the theme is wholly in control.
Created attachment 304990 [details] [review] docs: Improve deprecation notices for GtkMisc Point to the replacement properties and functions.
Created attachment 304991 [details] [review] docs: Improve deprecation notices for GtkSettings The button and menu item icons settings are deprecated; application developers should control whether or not a widget should show an icon, using the existing API.
Attachment 304987 [details] pushed as 7157771 - docs: Add deprecation notices for GtkAlignment properties Attachment 304988 [details] pushed as 5a61246 - docs: Improve deprecation notices for GtkImageMenuItem properties Attachment 304989 [details] pushed as 56faf49 - docs: Improve deprecation notice for rules-hint property Attachment 304990 [details] pushed as b493bf0 - docs: Improve deprecation notices for GtkMisc Attachment 304991 [details] pushed as d11e812 - docs: Improve deprecation notices for GtkSettings