After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750709 - souphttpsrc: add tls-interaction property
souphttpsrc: add tls-interaction property
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
Other Linux
: Normal enhancement
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-06-10 13:18 UTC by Xavier Claessens
Modified: 2015-12-14 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

souphttpsrc: Add GTlsInteraction property (4.60 KB, patch)
2015-06-10 13:18 UTC, Xavier Claessens
none Details | Review
souphttpsrc: Add GTlsInteraction property (5.29 KB, patch)
2015-12-14 17:13 UTC, Xavier Claessens
committed Details | Review

Description Xavier Claessens 2015-06-10 13:18:34 UTC
It is needed when the server request a client certificate.
Comment 1 Xavier Claessens 2015-06-10 13:18:55 UTC
Created attachment 304973 [details] [review]
souphttpsrc: Add GTlsInteraction property
Comment 2 Xavier Claessens 2015-06-10 13:24:28 UTC
SoupSession::tls-interaction property has been added in libsoup 2.48 which itself depend on glib 2.38. Currently -good depends on libsoup 2.40 and glib 2.32.

Options are:
1) Bump dependency
2) Delay merging this patch until we can bump dependency
3) Only bump libsoup dependency since it's optional plugin anyway
4) ifdef setting the tls-interaction on the SoupSession but then it would mean that the feature won't work depending on the version of libsoup at build-time, it's weird IMO.
Comment 3 Tim-Philipp Müller 2015-06-10 13:34:38 UTC
I don't think we should bump glib or libsoup before the 1.6 release. Let's wait with that afterwards.

So we can make the property optional (or non-functional if compiled against older libsoup) and document that, or wait.
Comment 4 Nicolas Dufresne (ndufresne) 2015-12-14 17:00:39 UTC
Review of attachment 304973 [details] [review]:

::: ext/soup/gstsouphttpsrc.c
@@ +388,3 @@
+   * user for passwords or certificate where necessary.
+   *
+   * Since: 1.6

Comment 5 Nicolas Dufresne (ndufresne) 2015-12-14 17:01:26 UTC
Please, also update the SOUP version check.
Comment 6 Nicolas Dufresne (ndufresne) 2015-12-14 17:04:14 UTC
And I don't see myself any issue with the update, Soup 2.48 is more then a year old, and will be even older by 1.8.
Comment 7 Xavier Claessens 2015-12-14 17:13:02 UTC
Created attachment 317385 [details] [review]
souphttpsrc: Add GTlsInteraction property
Comment 8 Tim-Philipp Müller 2015-12-14 17:14:40 UTC
Yes, I think bumping soup to 2.48 is okay now. We required glib 2.40 in master now, soup 2.48 requires 2.38, so that's fine too.
Comment 9 Nicolas Dufresne (ndufresne) 2015-12-14 20:11:25 UTC
Attachment 317385 [details] pushed as 10044b1 - souphttpsrc: Add GTlsInteraction property
Comment 10 Nicolas Dufresne (ndufresne) 2015-12-14 20:12:04 UTC
Thanks, security addict will be pleased.