Created attachment 304973 [details] [review]
souphttpsrc: Add GTlsInteraction property

SoupSession::tls-interaction property has been added in libsoup 2.48 which itself depend on glib 2.38. Currently -good depends on libsoup 2.40 and glib 2.32.

Options are:
1) Bump dependency
2) Delay merging this patch until we can bump dependency
3) Only bump libsoup dependency since it's optional plugin anyway
4) ifdef setting the tls-interaction on the SoupSession but then it would mean that the feature won't work depending on the version of libsoup at build-time, it's weird IMO.

I don't think we should bump glib or libsoup before the 1.6 release. Let's wait with that afterwards.

So we can make the property optional (or non-functional if compiled against older libsoup) and document that, or wait.

Review of attachment 304973 [details] [review]:

::: ext/soup/gstsouphttpsrc.c
@@ +388,3 @@
+   * user for passwords or certificate where necessary.
+   *
+   * Since: 1.6

1.8

Please, also update the SOUP version check.

And I don't see myself any issue with the update, Soup 2.48 is more then a year old, and will be even older by 1.8.

Created attachment 317385 [details] [review]
souphttpsrc: Add GTlsInteraction property

Yes, I think bumping soup to 2.48 is okay now. We required glib 2.40 in master now, soup 2.48 requires 2.38, so that's fine too.

Attachment 317385 [details] pushed as 10044b1 - souphttpsrc: Add GTlsInteraction property

Thanks, security addict will be pleased.