GNOME Bugzilla – Bug 750706
Wish: Make FTP backend optional
Last modified: 2015-06-17 21:37:56 UTC
A lot of backends are optional in gvfs, FTP is not. Commit 7cf5d5ff55fcbdebe0fb7b60e52ecb0c95ca63ee introduced a dependency on gcr, which is nearly as big as the gvfs package itself. I only need gvfs for Evince annotations and Thunar trash support and would like to maintain a slim system. Please add a compile option like --disable-ftp for those users who do not use this backend.
Created attachment 305101 [details] [review] build: Make GCR optional Make using GCR optional by compiling with --disable-gcr. This disables certificate checking with ftps, so don't silently disable it if the library is not found, only disable it if --disable-gcr is given.
(In reply to flo.xfce from comment #0) > A lot of backends are optional in gvfs, FTP is not. Commit > 7cf5d5ff55fcbdebe0fb7b60e52ecb0c95ca63ee introduced a dependency on gcr, > which is nearly as big as the gvfs package itself. I only need gvfs for > Evince annotations and Thunar trash support and would like to maintain a > slim system. > Please add a compile option like --disable-ftp for those users who do not > use this backend. gvfs only requires libgcr-base.so.1.0, which is 624k on my system, not really much :-) But anyway, here is a patch.
Ok, this has to do with packaging, libgcr-base is not packed separatly on my system. Anyway - thanks for the patch. I compiled it and it works fine as far as I can tell. Will this patch also be applied upstream?
(In reply to flo.xfce from comment #3) > Ok, this has to do with packaging, libgcr-base is not packed separatly on my > system. Anyway - thanks for the patch. I compiled it and it works fine as > far as I can tell. Will this patch also be applied upstream? Well it might be useful if whoever packages gcr splits it up appropriately. But yes, I do intend to apply the patch as soon as it's reviewed.
Review of attachment 305101 [details] [review]: (In reply to flo.xfce from comment #3) > Will this patch also be applied upstream? Hmm, why not, but... ::: configure.ac @@ +74,3 @@ giomodulesdir=$libdir/gio/modules AC_SUBST(giomodulesdir) dnl ********************* dnl *** Check for gcr *** dnl ********************* ::: daemon/gvfsdaemonutils.c @@ +362,3 @@ + GTlsCertificateFlags errors) +{ + return TRUE; Shouldn't be FALSE returned by default, i.e. be ssl strict?
Created attachment 305359 [details] [review] build: Make GCR optional Make using GCR optional by compiling with --disable-gcr. This makes gvfs strict when checking SSL certificates, so don't silently disable it if the library is not found, only disable it if --disable-gcr is given.
(In reply to Ondrej Holy from comment #5) > Review of attachment 305101 [details] [review] [review]: > > (In reply to flo.xfce from comment #3) > > Will this patch also be applied upstream? > > Hmm, why not, but... > > ::: configure.ac > @@ +74,3 @@ > giomodulesdir=$libdir/gio/modules > AC_SUBST(giomodulesdir) > > > dnl ********************* > dnl *** Check for gcr *** > dnl ********************* > > ::: daemon/gvfsdaemonutils.c > @@ +362,3 @@ > + GTlsCertificateFlags errors) > +{ > + return TRUE; > > Shouldn't be FALSE returned by default, i.e. be ssl strict? I suppose, yeah.
Review of attachment 305359 [details] [review]: Looks good, just you overlooked my first note probably: ::: configure.ac @@ +74,3 @@ giomodulesdir=$libdir/gio/modules AC_SUBST(giomodulesdir) Please add following header as is used in other cases... dnl ********************* dnl *** Check for gcr *** dnl *********************
(In reply to Ondrej Holy from comment #8) > Review of attachment 305359 [details] [review] [review]: > > Looks good, just you overlooked my first note probably: > > ::: configure.ac > @@ +74,3 @@ > giomodulesdir=$libdir/gio/modules > AC_SUBST(giomodulesdir) > > > Please add following header as is used in other cases... > > dnl ********************* > dnl *** Check for gcr *** > dnl ********************* Pushed to master as 600558ec7927d75ea045f3093a7db0a4778c76fe with the extra change. Thanks for the reviews!