After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750698 - [Genie] Move handling of var declaration to separate function
[Genie] Move handling of var declaration to separate function
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Genie
0.29.x
Other Linux
: Normal normal
: ---
Assigned To: Jamie McCracken
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-10 12:07 UTC by Al Thomas
Modified: 2015-11-26 16:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move handling of var declaration to a separate function to improve readability (2.37 KB, patch)
2015-06-10 12:07 UTC, Al Thomas 		none Details | Review
Tests for type inference (871 bytes, text/plain)
2015-06-10 12:08 UTC, Al Thomas 		  Details

Description Al Thomas 2015-06-10 12:07:05 UTC 
Created attachment 304958 [details] [review]
Move handling of var declaration to a separate function to improve readability

This patch moves the handling of a var declaration from parse_local_variable_declarations to a separate function called parse_type_inference_declaration. This is a re-factoring to improve readability of the Genie parser source code after a review for another patch. There is no functional change.
Comment 1 Al Thomas 2015-06-10 12:08:32 UTC 
Created attachment 304959 [details]
Tests for type inference

These are the tests the patch was run against. All tests pass for me.
Comment 2 Al Thomas 2015-11-26 16:06:36 UTC 
Fixed by patch applied from https://bugzilla.gnome.org/show_bug.cgi?id=746704