After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750663 - Highlighting doesn't work for Recent bookmark in sidebar of file chooser dialog
Highlighting doesn't work for Recent bookmark in sidebar of file chooser dialog
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
3.16.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2015-06-09 20:06 UTC by draymond
Modified: 2018-04-15 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description draymond 2015-06-09 20:06:25 UTC
This was observed on both Windows and OSX.  Note that code changes are needed to get the Recent bookmark to show at all (see bug ID 750068).  Once you get the bookmark showing the following issue is observed:

When the user selects the Recent bookmark it is displayed correctly in the right pane of the file chooser.  However, the bookmark itself is not highlighted.  It highlights when you first click it and then the highlighting quickly disappears so that none of the bookmarks are highlighted.  The other bookmarks do not exhibit this behavior.
Comment 1 Matthias Clasen 2015-06-12 12:26:00 UTC
Can you apply this patch and see what transpires ?

diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c
index f767e14..177e72a 100644
--- a/gtk/gtkplacessidebar.c
+++ b/gtk/gtkplacessidebar.c
@@ -4938,6 +4938,7 @@ gtk_places_sidebar_set_location (GtkPlacesSidebar *sidebar,
                           -1);
       if (iter_uri != NULL)
         {
+          g_print ("set location: comparing %s and %s\n", iter_uri, uri);
           if (strcmp (iter_uri, uri) == 0)
             {
               g_free (iter_uri);
Comment 2 draymond 2015-06-12 16:50:03 UTC
set location: comparing recent:/// and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/msys2/home/draymond and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/Users/draymond/Desktop and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/Users/draymond/Documents and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/Users/draymond/Downloads and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/Users/draymond/Music and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/Users/draymond/Pictures and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/Users/draymond/Videos and file:///C:/regression/data/gates/recent:
set location: comparing file:/// and file:///C:/regression/data/gates/recent:
set location: comparing file:///Z:/ and file:///C:/regression/data/gates/recent:
set location: comparing file:///H:/ and file:///C:/regression/data/gates/recent:
set location: comparing file:///D:/ and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/ and file:///C:/regression/data/gates/recent:
set location: comparing file:///C:/regression/data/gates and file:///C:/regression/data/gates/recent:
Comment 3 Matthias Clasen 2015-06-15 00:24:15 UTC
thanks, this explains it:

set location: comparing recent:/// and file:///C:/regression/data/gates/recent:

So, g_file_new ("recent:///") does not work as expected if gvfs does not support the recent scheme
Comment 4 draymond 2017-01-29 20:46:53 UTC
This bug still exists in 3.22.7.
Comment 5 Daniel Boles 2017-10-09 11:47:07 UTC

*** This bug has been marked as a duplicate of bug 763517 ***
Comment 6 draymond 2017-10-09 15:12:17 UTC
Dear Daniel Boles, please stop marking my tickets as resolved/duplicate.  How can this be a duplicate of a bug report that was filed 9 months after this one?  If the issue is not fixed don't mark the bug report as resolved.
Comment 7 Daniel Boles 2017-10-09 15:16:02 UTC
same reason as last time: the other bug describes almost certainly the same problem, but with more info, so the relative points in time at which they were posted doesn't matter.

most people don't feel the need to have their own personal copy of every bug they've ever encountered, but sure, keep it if you really want.
Comment 8 Matthias Clasen 2017-10-09 17:53:01 UTC
bugzilla is a tool for us, the developers. Your contribution is appreciated, but you don't get any ownership stake in the bugs you report. GTK+ has 2700+ open bugs. It is important for us to not make the pile unnecessarily bigger by keeping duplicates or near-duplicates or wontfixes open.
Comment 9 draymond 2017-10-10 05:01:07 UTC
Matthias we are both developers and I think we both appreciate the purpose of a bug tracking system.  Generally you don't mark a bug as duplicate unless you understand the root cause (and hence have a fix that resolves both bug reports).
Comment 10 Daniel Boles 2017-10-10 19:48:36 UTC
Please confirm whether the fix at https://bugzilla.gnome.org/show_bug.cgi?id=763517#c29 addresses this.
Comment 11 Matthias Clasen 2018-04-15 00:07:35 UTC
As announced a while ago, we are migrating to gitlab, and bugs that haven't seen activity in the last year or so will be not be migrated, but closed out in bugzilla.

If this bug is still relevant to you, you can open a new issue describing the symptoms and how to reproduce it with gtk 3.22.x or master in gitlab:

https://gitlab.gnome.org/GNOME/gtk/issues/new