After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750625 - Should dismiss Software Updates Available notification after installing updates
Should dismiss Software Updates Available notification after installing updates
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
2.44.x
Other Linux
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2015-06-09 11:37 UTC by Michael Catanzaro
Modified: 2015-06-23 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gapplication: Initialize backend before withdrawing notifications (1.32 KB, patch)
2015-06-22 18:23 UTC, Kalev Lember 		committed Details | Review

Description Michael Catanzaro 2015-06-09 11:37:22 UTC 
Should dismiss the Software Updates Available notification after installing updates, rather than displaying it alongside the Software Updates Installed notification.
Comment 1 Kalev Lember 2015-06-09 11:56:04 UTC 
gnome-software has code that's supposed to clear out old updates notifications each time it starts. Not sure what might be going wrong here ...

https://git.gnome.org/browse/gnome-software/tree/src/gs-update-monitor.c#n592
Comment 2 Kalev Lember 2015-06-22 18:23:01 UTC 
After some debugging, this turned out to be a bug in glib.

Even though its docs state that g_application_withdraw_notification() can be used to withdraw notifications from a previous run, this doesn't currently work in practice because it doesn't initialize its notification backend in the withdraw_notification() code path.
Comment 3 Kalev Lember 2015-06-22 18:23:34 UTC 
Created attachment 305849 [details] [review]
gapplication: Initialize backend before withdrawing notifications

Make sure to initialize the notification backend in
g_application_withdraw_notification() the same way as is done in
g_application_send_notification().

This makes it possible for an app to withdraw notifications it has sent
in a previous execution of the application.
Comment 4 Allison Karlitskaya (desrt) 2015-06-23 12:21:00 UTC 
Review of attachment 305849 [details] [review]:

looks good.  thanks.
Comment 5 Kalev Lember 2015-06-23 12:25:18 UTC 
Thanks desrt!

Attachment 305849 [details] pushed as c612fca - gapplication: Initialize backend before withdrawing notifications