After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750612 - Unimplemeneted annotation: POPPLER_ANNOT_SQUIGGLY, patch attached
Unimplemeneted annotation: POPPLER_ANNOT_SQUIGGLY, patch attached
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: pdf annotations
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-09 05:43 UTC by Philipp Reinkemeier
Modified: 2015-06-13 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
testcase for annotation squiggly (2.97 KB, application/pdf)
2015-06-09 05:43 UTC, Philipp Reinkemeier 		  Details
[PATCH 1/3] libdocument: adding annotation squiggly. (2.57 KB, patch)
2015-06-09 05:46 UTC, Philipp Reinkemeier 		committed Details | Review
[PATCH 2/3] pdf: adding annotation squiggly. (1.79 KB, patch)
2015-06-09 05:47 UTC, Philipp Reinkemeier 		committed Details | Review
[PATCH 3/3] shell: adding annotation squiggly. (3.19 KB, patch)
2015-06-09 05:48 UTC, Philipp Reinkemeier 		committed Details | Review

Description Philipp Reinkemeier 2015-06-09 05:43:36 UTC 
Created attachment 304825 [details]
testcase for annotation squiggly

Text markup annotations of subtype Squiggly are not supported yet.

Given that now the code for text markup annotations is in master and subtypes of it are merely just encoded with an enum, supporting the remaing subtype Squiggly is easy. The following three trivial patches add support for it.

For the safe of completeness, i am first attaching a testcase.
Comment 1 Philipp Reinkemeier 2015-06-09 05:46:25 UTC 
Created attachment 304826 [details] [review]
[PATCH 1/3] libdocument: adding annotation squiggly.

This adds the type to libdocument, as well as a method
to create such annotations.
Comment 2 Philipp Reinkemeier 2015-06-09 05:47:16 UTC 
Created attachment 304827 [details] [review]
[PATCH 2/3] pdf: adding annotation squiggly.

This adds support to the pdf backend for loading and saving text markup annotations of subtype Squiggly.
Comment 3 Philipp Reinkemeier 2015-06-09 05:48:32 UTC 
Created attachment 304828 [details] [review]
[PATCH 3/3] shell: adding annotation squiggly.

Underline icon is used for squiggly annotations in the sidebar.
Squiggly is now a supported markup type, selectable in the combo list in the annotation property dialog.
Comment 4 Carlos Garcia Campos 2015-06-13 07:41:55 UTC 
All pushed, thank you very much!