After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750574 - netclientclock: Make the clock a wrapper clock around an internal clock
netclientclock: Make the clock a wrapper clock around an internal clock
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-08 15:12 UTC by Sebastian Dröge (slomo)
Modified: 2015-06-09 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
netclientclock: Make the clock a wrapper clock around an internal clock (11.38 KB, patch)
2015-06-08 15:12 UTC, Sebastian Dröge (slomo)
committed Details | Review
netclientclock: Use the new GST_CLOCK_FLAG_NEEDS_STARTUP_SYNC flag (1.40 KB, patch)
2015-06-08 15:12 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2015-06-08 15:12:07 UTC
See commit message for reasoning
Comment 1 Sebastian Dröge (slomo) 2015-06-08 15:12:11 UTC
Created attachment 304783 [details] [review]
netclientclock: Make the clock a wrapper clock around an internal clock

The internal clock is only used for slaving against the remote clock, while
the user-facing GstClock can be additionally slaved to another clock if
desired. By default, if no master clock is set, this has exactly the same
behaviour as before. If a master clock is set (which was not allowed before),
the user-facing clock is reporting the remote clock as internal time and
slaves this to the master clock.

This also removes the weirdness that the internal time of the netclientclock
was always the system clock time, and not the remote clock time.
Comment 2 Sebastian Dröge (slomo) 2015-06-08 15:12:17 UTC
Created attachment 304785 [details] [review]
netclientclock: Use the new GST_CLOCK_FLAG_NEEDS_STARTUP_SYNC flag
Comment 3 Jan Schmidt 2015-06-09 05:23:17 UTC
Review of attachment 304783 [details] [review]:

Just changing all the references to priv->internal_clock makes the code a bit weird, but OK.
Comment 4 Jan Schmidt 2015-06-09 05:24:40 UTC
Review of attachment 304785 [details] [review]:

cool
Comment 5 Sebastian Dröge (slomo) 2015-06-09 08:04:11 UTC
commit 59d916a071e445ece94b7971263f272d69da43e4
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 8 17:10:56 2015 +0200

    netclientclock: Use the new GST_CLOCK_FLAG_NEEDS_STARTUP_SYNC flag
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750574

commit 558c0b97fc8b9ffe5a39563da72d9e29a511aa14
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 8 17:04:55 2015 +0200

    netclientclock: Make the clock a wrapper clock around an internal clock
    
    The internal clock is only used for slaving against the remote clock, while
    the user-facing GstClock can be additionally slaved to another clock if
    desired. By default, if no master clock is set, this has exactly the same
    behaviour as before. If a master clock is set (which was not allowed before),
    the user-facing clock is reporting the remote clock as internal time and
    slaves this to the master clock.
    
    This also removes the weirdness that the internal time of the netclientclock
    was always the system clock time, and not the remote clock time.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750574