After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750562 - mangle-tmpl.py: Do not cast bytes to str implicitly
mangle-tmpl.py: Do not cast bytes to str implicitly
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-08 12:51 UTC by Heinrich Fink
Modified: 2015-06-08 21:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes compilation with python3 (860 bytes, patch)
2015-06-08 12:51 UTC, Heinrich Fink 		none Details | Review

Description Heinrich Fink 2015-06-08 12:51:02 UTC 
Created attachment 304768 [details] [review]
Fixes compilation with python3

Compilation under Arch Linux failed, because python == python3, and mangle-tmpl.py attempts to implicitly cast bytes to str: 

  DOC   Scanning header files
Traceback (most recent call last):

+ Trace 235131

  • File "../../common/mangle-tmpl.py", line 125 in <module> 
    main()
  • File "../../common/mangle-tmpl.py", line 120 in main 
    '<fallback xmlns="http://www.w3.org/2003/XInclude" />' + \
TypeError: Can't convert 'bytes' object to str implicitly 
Makefile:976: recipe for target 'tmpl-build.stamp' failed

Attached patch should fix it, but neither do I really know what mangle-tmpl.py actually does, nor am I much of a python expert, so please review this mini-patch :)
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2015-06-08 21:09:14 UTC 
Sorry about that. In commit
http://cgit.freedesktop.org/gstreamer/common/commit/?id=d9a33530a24c3ea24a6e13bd343b440c5656740e

I replaced mangle-tmpl.py with a simpler solution. The new script passes
python3 -m py_compile mangle-db.py