After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750542 - Add a sepia filter
Add a sepia filter
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other All
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-06-08 08:24 UTC by Debarshi Ray
Modified: 2015-11-21 02:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add a sepia filter (4.82 KB, patch)
2015-06-08 08:25 UTC, Debarshi Ray 		none Details | Review

Description Debarshi Ray 2015-06-08 08:24:27 UTC 
This is common enough to be there in the built-in set of operations. There are a lot of implementations floating around on the Internet. W3C's upcoming Filter Effects spec seems to have a reasonably formal description of the algorithm: http://dev.w3.org/fxtf/filters
Comment 1 Debarshi Ray 2015-06-08 08:25:32 UTC 
Created attachment 304752 [details] [review]
Add a sepia filter
Comment 2 Øyvind Kolås (pippin) 2015-11-21 02:39:47 UTC 
commit 35b1d99716bca769889b67d8db75e9e9299a157b
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Jun 8 09:24:28 2015 +0200

    Add a sepia filter
    
    This implements the filer of the same name in the Filter Effects
    specification: http://dev.w3.org/fxtf/filters/
    
    The document says that filter functions must operate in the sRGB color
    space. However, it also describes the color-interpolation-filters
    property, which is set to linear by default, for the filtering
    primitives used to implement the functions. Since sepia is a thin
    wrapper around the feColorMatrix primitive, we ignore what the
    specification says about the filter function, and expose the
    color-interpolation-filters property on the filter operation.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750542