GNOME Bugzilla – Bug 750518
firfilter shall support individual filters per channel
Last modified: 2018-11-03 15:00:45 UTC
Created attachment 304726 [details] git patch The audiofirfilter supports so far only applying one filter for all audio channels. For several applications as e.g. digital room correction (DRC) it makes sense to support one filter kernel per channel to allow for channel specific correction due to e.g. unsymmetrical speaker placement. The attached patches implement the multichannel feature to the FIR filter in a way of a new interface which is fully backward compatible and works even simultaneously with the original interface (one code path for both). This was done for time domain filtering as well as frequency domain. The unit test got updated to test all interfaces and their interaction too as well as the time and frequency domain application. I attached the patches and stored everything in my fork on github: https://github.com/TheBigW/gst-plugins-good.git in the multi_channel_fir branch The DRC plugin project for rhythmbox already uses this feature (successful :) ) and depends on it : https://github.com/TheBigW/DRC.git.
Created attachment 316271 [details] [review] fixed previous erros in implementation already unit tested and used in DRC RB project. Also tested by DRC application and control measurements.
Can you re-attach your patch set please? All I get when I try to see it is garbled output. Additionally, squashing the set together might make reviewing easier. Thanks!
Created attachment 316547 [details] [review] unzipped version of the patch
(In reply to tobiaswenig from comment #3) > Created attachment 316547 [details] [review] [review] > unzipped version of the patch sorry, was an old habit to zip everything and I still selected "patch". Now also added the unzipped version of it.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/190.