After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750516 - balsa-2.5.2: balsa-mailto-handler.desktop has bogus entry
balsa-2.5.2: balsa-mailto-handler.desktop has bogus entry
Status: RESOLVED FIXED
Product: balsa
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Balsa Maintainers
Balsa Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-07 11:54 UTC by Pacho Ramos
Modified: 2015-06-08 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pacho Ramos 2015-06-07 11:54:50 UTC
I get:
$ desktop-file-validate /usr/share/applications/balsa-mailto-handler.desktop
/usr/share/applications/balsa-mailto-handler.desktop: error: value "@TOOLKIT_CATEGORIES@Network;Email;" for key "Categories" in group "Desktop Entry" contains an unregistered value "@TOOLKIT_CATEGORIES@Network"; values extending the format should start with "X-"
/usr/share/applications/balsa-mailto-handler.desktop: hint: value item "Email" in key "Categories" in group "Desktop Entry" can be extended with another category among the following categories: Office, or Network
/usr/share/applications/balsa-mailto-handler.desktop: hint: value "@TOOLKIT_CATEGORIES@Network;Email;" for key "Categories" in group "Desktop Entry" does not contain a registered main category; application might only show up in a "catch-all" section of the application menu

And, indeed, it looks something wasn't replaced as expected:
$ cat /usr/share/applications/balsa-mailto-handler.desktop
[Desktop Entry]
Name=Balsa
Name[es]=Balsa
Comment=E-Mail utility
Comment[es]=Utilidad de correo-e
GenericName=Mail Client
X-GNOME-FullName=Balsa Mail Client
TryExec=balsa
Exec=balsa -m %U
Icon=gnome-balsa2
Terminal=false
Type=Application
StartupNotify=true
Categories=@TOOLKIT_CATEGORIES@Network;Email;
MimeType=x-scheme-handler/mailto;
NoDisplay=true
Comment 1 Peter Bloomfield 2015-06-07 22:38:02 UTC
Thanks for catching this! 

The extra desktop file balsa-mailto-handler.desktop was installed in git master, and the TOOLKIT_CATEGORIES macro was implemented at the same time, so that Balsa's categories are GNOME;GTK;Network;Email when built for GNOME, and just GTK;Network;Email otherwise. When those changes were ported to the gtk3 branch, the macro definition was omitted, hence the bogus "Categories" entry.

Incidentally, in the gtk3 branch, balsa.desktop.in.in was never patched to use that macro. So it didn't have the bogus entry, but it asserted that it was a GNOME app even when not built for GNOME!

All fixed in git. Resolving as FIXED...
Comment 2 Pacho Ramos 2015-06-08 17:18:06 UTC
Thanks for fixing it so fast :)