After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750493 - Missing include prevents qt-gstreamer tests from building
Missing include prevents qt-gstreamer tests from building
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: qt-gstreamer
git master
Other Mac OS
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-06 15:30 UTC by hannes.weisbach
Modified: 2015-06-09 08:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.05 KB, patch)
2015-06-08 11:32 UTC, hannes.weisbach 		committed Details | Review

Description hannes.weisbach 2015-06-06 15:30:16 UTC 
The test "discoverer test" in tests/auto #includes <gst/pbutils/pbutils.h>. However, GSTREAMER_PBUTILS_INCLUDE_DIR is not in the include_directories list. Usually, there is no problem, because <gst/pbutils/pbutils.h> would be in <prefix>/include/gstreamer-1.0/, which is included as GSTREAMER_INCLUDE_DIR.

On OS X, the brew package manager installs every package in its own prefix and symlinks them into /usr/local. When building, it uses the prefix where the package is actually installed. Thus, not having GSTREAMER_PBUTILS_INCLUDE_DIR in include_directories results in pbutils.h not being found.

The fix is to include ${GSTREAMER_PBUTILS_INCLUDE_DIR} in the include_directories() directive in tests/auto/CMakeLists.txt.
Comment 1 Tim-Philipp Müller 2015-06-06 15:56:02 UTC 
Could you make a patch please?
Comment 2 hannes.weisbach 2015-06-08 11:32:14 UTC 
Created attachment 304762 [details] [review]
Proposed patch
Comment 3 Sebastian Dröge (slomo) 2015-06-09 08:17:55 UTC 
commit 77e58dae634fa1b282c64d435d32a2998c671b39
Author: Hannes Weisbach <hannes.weisbach@mailbox.tu-dresden.de>
Date:   Sun Jun 7 13:37:48 2015 +0200

    Add pbutils include directory to include paths
    
    Add directory with pbutils headers to the include_directories directive
    for the auto tests.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750493