GNOME Bugzilla – Bug 750480
Fix -Werror build for clang
Last modified: 2015-06-09 10:02:39 UTC
libgdata was switched to autoconf-archive and enabled -Werror recently. The attached patch fixes -Werror build when compiling with clang.
Created attachment 304687 [details] [review]
[PATCH] build: Fix -Werror build for clang
Review of attachment 304687 [details] [review]:
The changes to the unit tests are incorrect — those functions are currently unused because the tests need updating, not because the tests need removing. The compiler warnings are there as a reminder of this, so simply removing the code is the wrong approach. The tests need to be fixed.
The change to GDataBatchFeed is good — please split it out into a separate patch.
@@ +125,3 @@
g_assert (klass->parse_error_response != NULL);
+ klass->parse_error_response (service, (GDataOperationType) op->type, status_code,
+ status_reason, (gchar*) xmlBufferContent (status_response),
This bit is valuable; please split it out into a separate patch.
Created attachment 304829 [details] [review]
build: Fix -Werror build for clang
All changes to tests are removed. I added --disable-always-build-tests to my configure arguments, so I can keep testing -Werror without modifying tests.
Review of attachment 304829 [details] [review]:
Great, please commit this one, thanks.
Attachment 304829 [details] pushed as 1dd9274 - build: Fix -Werror build for clang