After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750478 - The year view should update the sidebar content when activated
The year view should update the sidebar content when activated
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: User Interface
3.17.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-06 11:06 UTC by Javier Sánchez Ochando
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
year-view: Not in sync with month-view (4.14 KB, patch)
2016-10-06 02:59 UTC, Isaque Galdino
committed Details | Review

Description Javier Sánchez Ochando 2015-06-06 11:06:25 UTC
If you select a date in the month view and then change to the year view, this shows events of the last date selected in the year view.

I think that the year view should update to show events of the active-date, when activated.
Comment 1 Erick Perez Castellanos 2015-10-29 13:49:18 UTC
(In reply to Javier Sánchez Ochando from comment #0)
> If you select a date in the month view and then change to the year view,
> this shows events of the last date selected in the year view.
> 
> I think that the year view should update to show events of the active-date,
> when activated.

How is it that you're selecting the date on month-view?
Comment 2 Javier Sánchez Ochando 2016-03-26 11:38:57 UTC
(In reply to Erick Perez Castellanos from comment #1)
> (In reply to Javier Sánchez Ochando from comment #0)
> > If you select a date in the month view and then change to the year view,
> > this shows events of the last date selected in the year view.
> > 
> > I think that the year view should update to show events of the active-date,
> > when activated.
> 
> How is it that you're selecting the date on month-view?

I thought I could activate a date clicking on any day on month-view.

Maybe it would be interesting to sync the active date on all views. In fact, this behaviour occurs when you select a date on year-view and change to month-view, but not the other way around.
Comment 3 Isaque Galdino 2016-10-06 02:59:41 UTC
Created attachment 337034 [details] [review]
year-view: Not in sync with month-view

When user changes the date in month-view, there is no sync with
year-view. The other way around works just fine, when user selects a
date in year-view, month-view goes to the same date.

Both views share an "active-date", but year-view doesn't obey that
property in some cases. Month-view also doesn't warn when changing that
property.

This commit fixes both views to keep them in sync, updating and using
"active-date" correctly.
Comment 4 Georges Basile Stavracas Neto 2016-10-06 03:04:56 UTC
Review of attachment 337034 [details] [review]:

Only a minor nitpick.

::: src/gcal-year-view.c
@@ +179,3 @@
+
+  if (needs_reset)
+    reset_sidebar (year_view);

Worth writing a small comment briefly explaining why the sidebar is not always reset.
Comment 5 Georges Basile Stavracas Neto 2016-10-06 03:15:36 UTC
Comment on attachment 337034 [details] [review]
year-view: Not in sync with month-view

Per IRC talk, I misunderstood the patch. Looks good.
Comment 6 Isaque Galdino 2016-10-06 03:29:45 UTC
Thanks for the bug report.

Attachment 337034 [details] pushed as 7c01508 - year-view: Not in sync with month-view