GNOME Bugzilla – Bug 750478
The year view should update the sidebar content when activated
Last modified: 2017-04-17 18:20:40 UTC
If you select a date in the month view and then change to the year view, this shows events of the last date selected in the year view. I think that the year view should update to show events of the active-date, when activated.
(In reply to Javier Sánchez Ochando from comment #0) > If you select a date in the month view and then change to the year view, > this shows events of the last date selected in the year view. > > I think that the year view should update to show events of the active-date, > when activated. How is it that you're selecting the date on month-view?
(In reply to Erick Perez Castellanos from comment #1) > (In reply to Javier Sánchez Ochando from comment #0) > > If you select a date in the month view and then change to the year view, > > this shows events of the last date selected in the year view. > > > > I think that the year view should update to show events of the active-date, > > when activated. > > How is it that you're selecting the date on month-view? I thought I could activate a date clicking on any day on month-view. Maybe it would be interesting to sync the active date on all views. In fact, this behaviour occurs when you select a date on year-view and change to month-view, but not the other way around.
Created attachment 337034 [details] [review] year-view: Not in sync with month-view When user changes the date in month-view, there is no sync with year-view. The other way around works just fine, when user selects a date in year-view, month-view goes to the same date. Both views share an "active-date", but year-view doesn't obey that property in some cases. Month-view also doesn't warn when changing that property. This commit fixes both views to keep them in sync, updating and using "active-date" correctly.
Review of attachment 337034 [details] [review]: Only a minor nitpick. ::: src/gcal-year-view.c @@ +179,3 @@ + + if (needs_reset) + reset_sidebar (year_view); Worth writing a small comment briefly explaining why the sidebar is not always reset.
Comment on attachment 337034 [details] [review] year-view: Not in sync with month-view Per IRC talk, I misunderstood the patch. Looks good.
Thanks for the bug report. Attachment 337034 [details] pushed as 7c01508 - year-view: Not in sync with month-view