GNOME Bugzilla – Bug 750471
rtspsrc: Add support for TLS client authentication
Last modified: 2015-06-10 00:08:49 UTC
GstRTSPSrc should have a GTlsInteraction property to send a certificate to server.
Did you mean to attach a patch?
Yes, finishing the corresponding patch on gst-rtsp-server for testing together first.
Created attachment 304718 [details] [review] GstRTSPConnection: Add GTlsInteraction support
Created attachment 304719 [details] [review] rtspsrc: Add a GTlsInteraction property It can be used for TLS client authentication.
Created attachment 304720 [details] [review] GstRTSPAuth: Add client certificate authentication support
Note that for this to be useful you need to pass a GTlsInteraction subclass that implement request_certificate() which has been added in glib 2.40. But it afaik it still build fine even with gst's current glib 2.32.
Review of attachment 304720 [details] [review]: ::: gst/rtsp-server/rtsp-auth.c @@ +570,3 @@ + + g_signal_connect (tls, "accept-certificate", + G_CALLBACK (accept_certificate_cb), auth); I think you should instead add a "accept-certificate" signal on the GstRTSPAuth object. This implementation does nothing, as it is the default behavior.
Created attachment 304903 [details] [review] GstRTSPAuth: Add client certificate authentication support
Created attachment 304906 [details] [review] rtspsrc: Add a GTlsInteraction property It can be used for TLS client authentication.
Comment on attachment 304718 [details] [review] GstRTSPConnection: Add GTlsInteraction support Committed to gst-p-base commit 74a434761403fbc491af7b564dcb102c81815888 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Fri Jun 5 22:04:24 2015 -0400 GstRTSPConnection: Add GTlsInteraction support https://bugzilla.gnome.org/show_bug.cgi?id=750471
Comment on attachment 304906 [details] [review] rtspsrc: Add a GTlsInteraction property Committed to gst-p-good: commit b0b3e8e2cc5820851ed9b2c785ba4f0b47f73a2c Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Sat Jun 6 21:09:19 2015 -0400 rtspsrc: Add a GTlsInteraction property It can be used for TLS client authentication. https://bugzilla.gnome.org/show_bug.cgi?id=750471
Comment on attachment 304903 [details] [review] GstRTSPAuth: Add client certificate authentication support Commited ot gst-rtsp-server: commit 6ec8fe44b2da3b61f8b2e0132eeb3a3f81cd7c95 Author: Xavier Claessens <xavier.claessens@collabora.com> Date: Fri Jun 5 22:35:39 2015 -0400 GstRTSPAuth: Add client certificate authentication support https://bugzilla.gnome.org/show_bug.cgi?id=750471