After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750461 - Return with G_SOURCE_REMOVE
Return with G_SOURCE_REMOVE
Status: RESOLVED FIXED
Product: java-atk-wrapper
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: java-atk-wrapper maintainer(s)
java-atk-wrapper maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-05 16:59 UTC by Magdalen Berns (irc magpie)
Modified: 2015-06-06 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to address problem (14.98 KB, patch)
2015-06-05 17:02 UTC, Magdalen Berns (irc magpie) 		committed Details | Review

Description Magdalen Berns (irc magpie) 2015-06-05 16:59:48 UTC 
After freeing the callback it would probably be better to return G_SOURCE_REMOVE which is a macro return value of a GSourceFunc.[1]

G_SOURCE_REMOVE is false to remove the GSource from the main loop.

[1] https://developer.gnome.org/glib/stable/glib-The-Main-Event-Loop.html#G-SOURCE-REMOVE:CAPS
Comment 1 Magdalen Berns (irc magpie) 2015-06-05 17:02:14 UTC 
Created attachment 304660 [details] [review]
Patch to address problem