After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750406 - audioconvert: copy all metadata.
audioconvert: copy all metadata.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-06-04 16:00 UTC by Mathieu Duponchelle
Modified: 2015-06-29 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
audioconvert: copy all metadata. (1.95 KB, patch)
2015-06-04 16:00 UTC, Mathieu Duponchelle
rejected Details | Review
audioconvert: copy metadata that only has the "audio" tag. (2.17 KB, patch)
2015-06-04 16:43 UTC, Mathieu Duponchelle
committed Details | Review
audiofilter: copy metadata that only has the "audio" tag. (1.76 KB, patch)
2015-06-04 17:01 UTC, Mathieu Duponchelle
committed Details | Review
audioresample: copy metadata that only has the "audio" tag. (2.29 KB, patch)
2015-06-04 17:04 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2015-06-04 16:00:25 UTC
I'm not sure which metadata should be invalidated by this, but
I think it's better than just dropping them all.
Comment 1 Mathieu Duponchelle 2015-06-04 16:00:30 UTC
Created attachment 304593 [details] [review]
audioconvert: copy all metadata.
Comment 2 Sebastian Dröge (slomo) 2015-06-04 16:03:18 UTC
Comment on attachment 304593 [details] [review]
audioconvert: copy all metadata.

See discussion on IRC:

<Mathieu_Du> Hey, shouldn't audioconvert copy metas by default ?
<Mathieu_Du> Not sure which metas it might want to invalidate, but I think just copying all of them would be more correct as just discarding them
<Mathieu_Du> than*
<slomo> no it would be more wrong
<slomo> there are audio metas that depend on the number of channels for example
<slomo> it's better to drop metas than having invalid metas on buffers
<slomo> it's really the same story as for video, i think you opened a bug about that some months ago ;)
Comment 3 Mathieu Duponchelle 2015-06-04 16:43:38 UTC
Created attachment 304596 [details] [review]
audioconvert: copy metadata that only has the "audio" tag.
Comment 4 Mathieu Duponchelle 2015-06-04 17:01:24 UTC
Created attachment 304597 [details] [review]
audiofilter: copy metadata that only has the "audio" tag.
Comment 5 Mathieu Duponchelle 2015-06-04 17:04:11 UTC
Created attachment 304598 [details] [review]
audioresample: copy metadata that only has the "audio" tag.
Comment 6 Mathieu Duponchelle 2015-06-04 17:18:50 UTC
Review of attachment 304596 [details] [review]:

commit 88484399c5d06ad27353cba706bf3cafef67729c
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Thu Jun 4 17:59:17 2015 +0200

    audioconvert: copy metadata that only has the "audio" tag.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750406
Comment 7 Mathieu Duponchelle 2015-06-04 17:19:07 UTC
Review of attachment 304597 [details] [review]:

commit 579967278a734b16b24bf179063d3b7bb724b099
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Thu Jun 4 19:00:45 2015 +0200

    audiofilter: copy metadata that only has the "audio" tag.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750406
Comment 8 Mathieu Duponchelle 2015-06-04 17:19:21 UTC
Review of attachment 304598 [details] [review]:

commit 2ad27e4c138949ae0cff8584723706b929bd6e56
Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com>
Date:   Thu Jun 4 19:03:51 2015 +0200

    audioresample: copy metadata that only has the "audio" tag.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750406
Comment 9 Sebastian Dröge (slomo) 2015-06-29 11:10:05 UTC
Just a follow-up:

commit c5dbee33b0a9da4b359357d72d462399eb9e4986
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 29 13:06:59 2015 +0200

    audioresample: Also copy metas if their API has no tags attached to it
    
    This is the default basetransform behaviour, being more strict than that
    is not really useful.

commit 010e35afa7ae6bab616430cd2315a0884ebc539c
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 29 13:06:49 2015 +0200

    audioconvert: Also copy metas if their API has no tags attached to it
    
    This is the default basetransform behaviour, being more strict than that
    is not really useful.

commit 0acdfeed690f44ad3baed89ccec464252f26778f
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 29 13:06:33 2015 +0200

    audiofilter: Also copy metas if their API has no tags attached to it
    
    This is the default basetransform behaviour, being more strict than that
    is not really useful.

commit 4bb9548026b84a2f408d2b2c1191d86cecaf09d3
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon Jun 29 13:05:54 2015 +0200

    videofilter: Also copy metas if their API has no tags attached to it
    
    This is the default basetransform behaviour, being more strict than that
    is not really useful.