After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750405 - [review] detect route-metric when creating nm-generated-assumed connection
[review] detect route-metric when creating nm-generated-assumed connection
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-04 15:54 UTC by Thomas Haller
Modified: 2015-06-05 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: detect route-metric when creating nm-generated-assumed connection (13.05 KB, patch)
2015-06-04 15:55 UTC, Thomas Haller 		none Details | Review

Description Thomas Haller 2015-06-04 15:54:19 UTC 
attaching patch...
Comment 1 Thomas Haller 2015-06-04 15:55:15 UTC 
Created attachment 304592 [details] [review]
core: detect route-metric when creating nm-generated-assumed connection

When generating a connection to assume it, also record the route-metric.
Do that by looking at the metric of the (best) default-route.

This is especially important since d51975ed921a5876b76e081b8f3df4e2ca1f1ca9.
Now NM would also manage the default-route for assumed connections.
So the generated assumed connection would have a route metric based on
the device type, which might differ from the external configuration.
This caused NM to replace the externally configured default-route.
Comment 2 Beniamino Galvani 2015-06-05 08:27:57 UTC 
LGTM and works fine.