After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750368 - Tracker fails to configure with gstreamer support disabled
Tracker fails to configure with gstreamer support disabled
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
1.4.x
Other Linux
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2015-06-03 22:37 UTC by Gilles Dartiguelongue
Modified: 2015-07-12 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix AM_CONDITIONAL position (1.31 KB, patch)
2015-06-03 22:37 UTC, Gilles Dartiguelongue
committed Details | Review

Description Gilles Dartiguelongue 2015-06-03 22:37:36 UTC
Created attachment 304558 [details] [review]
Fix AM_CONDITIONAL position

From our downstream bug report,

configure.ac has AM_CONDITIONAL and AC_DEFINES for HAVE_GSTREAMER however AM_CONDITIONAL cannot be placed in a if structure, otherwise, it is simply discarded.

Attached patch solves this problem, it was the only occurence of such problem in the file. It also fixes the double AC_DEFINE of HAVE_GSTREAMER as the second was probably intended to be HAVE_LIBAV. It appears this define is not used currently, but just in case, it's there.
Comment 1 Sam Thursfield 2015-07-05 12:58:17 UTC
Thanks for this!

A similar fix was sent to the mailing list and was merged: https://git.gnome.org/browse/tracker/commit/?id=d93944050c7d6d1df10aaca18d4c60794ab72a05

That fixes the configure failure when gstreamer is disabled, in a slightly different way. It doesn't fix the HAVE_LIBAV thing which you spotted, though.
Comment 2 Martyn Russell 2015-07-12 18:44:03 UTC
This has been fixed in commit, thanks for the patch! :)

commit 37cfed8a227a813def71535f81a1066680329cd0
Author: Gilles Dartiguelongue <eva@gentoo.org>
Date:   Sun Jul 12 19:41:02 2015 +0100

    build: Fix AM_CONDITIONAL position HAVE_{GSTREAMER,LIBAV} definition
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750368