After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750332 - rtpsession: Add support for reduced size rtcp
rtpsession: Add support for reduced size rtcp
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 750325
Blocks:
 
 
Reported: 2015-06-03 11:16 UTC by Jose Antonio Santos Cadenas
Modified: 2015-06-05 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtpsession: Add support for reduced size rtcp (897 bytes, patch)
2015-06-03 11:16 UTC, Jose Antonio Santos Cadenas
none Details | Review
rtpsession: Add support for receiving reduced size rtcp (907 bytes, patch)
2015-06-03 12:12 UTC, Jose Antonio Santos Cadenas
committed Details | Review

Description Jose Antonio Santos Cadenas 2015-06-03 11:16:48 UTC
Created attachment 304484 [details] [review]
rtpsession: Add support for reduced size rtcp

Attached patch adds support for reduced size RTCP packages
Comment 1 Sebastian Dröge (slomo) 2015-06-03 11:28:15 UTC
Review of attachment 304484 [details] [review]:

I don't think this is complete. I remember seeing code in rtpsession or rtpsource that assumed that RTCP packets start with SR/RR.


Also you probably want to change the commit message to say "Add support for *receiving* reduced size RTCP" :) However adding support for sending it is also trivial, just add a property for that and then do some more is_early && do_reduced_size checks during RTCP generation. You can make all early RTCP packets reduced size.
Comment 2 Jose Antonio Santos Cadenas 2015-06-03 12:11:56 UTC
Let't change the commit message by now :)
Comment 3 Jose Antonio Santos Cadenas 2015-06-03 12:12:38 UTC
Created attachment 304499 [details] [review]
rtpsession: Add support for receiving reduced size rtcp
Comment 4 Sebastian Dröge (slomo) 2015-06-05 08:28:27 UTC
commit f8f23bbf5da08fda939ec75d2cfe455134066415
Author: Jose Antonio Santos Cadenas <santoscadenas@gmail.com>
Date:   Wed Jun 3 13:14:44 2015 +0200

    rtpsession: Add support for receiving reduced size rtcp
    
    See RFC 5506
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750332
Comment 5 Sebastian Dröge (slomo) 2015-06-05 08:36:15 UTC
Now we only have to add support for actually sending reduced size RTCP. Are you looking into this? Otherwise I'll do in a bit, it's relatively simple.
Comment 6 Jose Antonio Santos Cadenas 2015-06-05 08:44:13 UTC
No, I just wanted to allow receiving reduced packets.
Comment 7 Sebastian Dröge (slomo) 2015-06-05 08:48:44 UTC
You should report a bug to whatever is sending you reduced size RTCP without negotiating this first.
Comment 8 Jose Antonio Santos Cadenas 2015-06-05 09:16:28 UTC
In fact RFC says that is not mandatory no negotiate, but just to notify in SDP. Nevertheless, the bug has been reported because it was not notified. My guess it that this situation will become common with more clients, so its better to allow reception  of reduced RTCP even if it is not notified.
Comment 9 Sebastian Dröge (slomo) 2015-06-05 09:30:21 UTC
IIRC the RFC says to make sure that the other side can actually receive reduced size RTCP, and even implement heuristics to detect if some middle box in between drops the packets. Whatever sent those packets probably did any of this.
Comment 10 Jose Antonio Santos Cadenas 2015-06-05 11:07:55 UTC
Probably not, because reduced size rtcp didn't stop even when they were not processed.
Comment 11 Sebastian Dröge (slomo) 2015-06-05 11:20:58 UTC
Which software was that?
Comment 12 Jose Antonio Santos Cadenas 2015-06-05 12:22:06 UTC
Chrome 44
Comment 13 Nicolas Dufresne (ndufresne) 2015-06-05 13:39:20 UTC
I would blame the JS to not have implemented re-negoatiation.
Comment 14 Jose Antonio Santos Cadenas 2015-06-05 14:54:12 UTC
The offer generated by chrome does not seem to have required attribute a=rtcp-rsize as defined here: https://tools.ietf.org/html/rfc5506#section-5