GNOME Bugzilla – Bug 750330
Vodafone SIM superceded by ASDA settings
Last modified: 2015-06-10 13:07:36 UTC
We have a Vodafone SIM with MNC 15, in use in UK so MCC=234 http://www.mcc-mnc.com/ correctly documents MCC=234 as GB and MNC=15 as Vodafone. The correct Vodafone settings are present in serviceproviders.xml here https://git.gnome.org/browse/mobile-broadband-provider-info/tree/serviceproviders.xml#n4902 However there are other settings for ASDA mobile present earlier in the file which are thus being used for Vodafone SIMs which seems incorrect https://git.gnome.org/browse/mobile-broadband-provider-info/tree/serviceproviders.xml#n4696 I see there is a similar issue filed here https://bugs.launchpad.net/ubuntu/+source/mobile-broadband-provider-info/+bug/1253586 Can somebody advise if this is actually a bug? I would expect settings for Vodafone to be prior to settings for ADSA mobile? Thanks
Created attachment 304651 [details] [review] [patch] gb: move "Asda Mobile" after "Vodafone" How about this?
That seems a very good idea to me. There's a similar issue with O2 as GiffGaff takes precedence, which could also be addressed by moving GiffGaff after O2. Of course then ADSA Mobile and GiffGaff would not work out of the box but perhaps it is reasonable to give preference to defaults for larger "real" telcos rather than the virtual telcos sitting on top of them?
Please be aware of bug 742838. Moving Vodafone on top of the MNVO operator is for now a good approach, but we should still decide whether we want to specify MCCMNC for MVNOs in some other new key (but what for?) or just ignore them.
> Moving Vodafone on top of the MNVO operator is for now a good approach It's a good approach just because we use a sequential parser in the implementation making us e of this info in NetworkManager, so the first operator with a given MCCMNC is the one being used. I don't know whether other parsers do the same or not. The correct solution would be to track the MCCMNCs of MVNOs (could even be >1 I suppose) in a separate key (e.g. virtual-network-id, as suggested in https://bugzilla.gnome.org/show_bug.cgi?id=742838#c1). The only reason I can see to use this info is when the UI exposing the operator name wants to show whether the modem is roaming or not. If the device is roaming on a network with a MCCMNC listed as valid in the MVNO, we shouldn't show "roaming" state. BUT, this info can already be gathered from the SIM card itself, so not sure why we would want to have this list.
(In reply to Aleksander Morgado from comment #3) > Moving Vodafone on top of the MNVO operator is for now a good approach. Thanks. (In reply to Alex J Lennon from comment #2) > That seems a very good idea to me. merged to master: https://git.gnome.org/browse/mobile-broadband-provider-info/commit/?id=a967b14aef419bd37dda467dfa2fae6c2f51ae1a > There's a similar issue with O2 as GiffGaff takes precedence, which could > also be addressed by moving GiffGaff after O2. Fixed too: https://git.gnome.org/browse/mobile-broadband-provider-info/commit/?id=4c6b2437b71580ed8a14e1b5029a2cdace76c6d4
Thanks Aleksander, Thomas