After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750229 - Make past actions in a discussion links to themselves
Make past actions in a discussion links to themselves
Status: RESOLVED FIXED
Product: damned-lies
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: damned-lies Maintainer(s)
damned-lies Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-06-01 16:34 UTC by Alexandre Franke
Modified: 2015-06-03 08:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Actions now have links (1.30 KB, patch)
2015-06-01 16:35 UTC, Alexandre Franke 		none Details | Review
Actions now have links (1.34 KB, patch)
2015-06-02 20:42 UTC, Alexandre Franke 		none Details | Review
Actions now have links (1.26 KB, patch)
2015-06-02 20:56 UTC, Alexandre Franke 		committed Details | Review

Description Alexandre Franke 2015-06-01 16:34:57 UTC 
It is possible to go to a specific comment in a discussion since there's an
anchor for each of them, but there's no link to it. I fix this by making the
action description a link to the action.
Comment 1 Alexandre Franke 2015-06-01 16:35:00 UTC 
Created attachment 304364 [details] [review]
Actions now have links
Comment 2 Claude Paroz 2015-06-02 07:31:03 UTC 
Took some time to look at it this morning. I understand the need, but I'd rather have something a bit less unobtrusive. When you see a link with underline text, this generally mean that clicking on it brings you somewhere else, which is not the case here.
For example, we could have some link icon (right-aligned?) with an appropriate title ("Link to this comment") which people can use to copy the link. Does that make sense?
Comment 3 Alexandre Franke 2015-06-02 08:55:00 UTC 
I see what you mean and it totally makes sense. I'll work on something later today.
Comment 4 Alexandre Franke 2015-06-02 20:42:59 UTC 
Created attachment 304458 [details] [review]
Actions now have links
Comment 5 Alexandre Franke 2015-06-02 20:43:53 UTC 
How about that? :-)

Matches what I've seen on some online forums.
Comment 6 Claude Paroz 2015-06-02 20:47:32 UTC 
Looks better, indeed. Is the url part really needed in the href, or would the '#...' part sufficient?
Comment 7 Alexandre Franke 2015-06-02 20:56:10 UTC 
Created attachment 304459 [details] [review]
Actions now have links

That's a very good point, I forgot that you could do this. Here's hopefully the
final version of this trivial patch. :-)
Comment 8 Claude Paroz 2015-06-03 07:50:08 UTC 
Review of attachment 304459 [details] [review]:

Push it!
Comment 9 Alexandre Franke 2015-06-03 08:16:13 UTC 
Attachment 304459 [details] pushed as e26c0d5 - Actions now have links