After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750162 - android: NDK r10e does not set HOST_SED anymore
android: NDK r10e does not set HOST_SED anymore
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: dont know
git master
Other Linux
: Normal blocker
: 1.5.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-30 22:22 UTC by Nicolas Dufresne (ndufresne)
Modified: 2015-08-16 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
android-bootstrap: Don't hide installation failure (1.29 KB, patch)
2015-08-10 02:23 UTC, Nicolas Dufresne (ndufresne) 		accepted-commit_now Details | Review
android: Update to NDK r10e (2.10 KB, patch)
2015-08-10 02:23 UTC, Nicolas Dufresne (ndufresne) 		accepted-commit_now Details | Review
android: Import definition of HOST_SED (1.12 KB, patch)
2015-08-10 02:23 UTC, Nicolas Dufresne (ndufresne) 		accepted-commit_now Details | Review

Description Nicolas Dufresne (ndufresne) 2015-05-30 22:22:41 UTC 
In latest NDK, HOST_SED is not set anymore. Our build system breaks silently in that case (trying to execute -n).
Comment 1 Sebastian Dröge (slomo) 2015-06-01 11:25:53 UTC 
Is there still a sed shipped with the NDK or do we have to bundle ours for Windows?
Comment 2 Nicolas Dufresne (ndufresne) 2015-06-01 12:09:07 UTC 
I's sill shipped, it's just the define that is gone.
Comment 3 Nicolas Dufresne (ndufresne) 2015-08-10 02:23:12 UTC 
Created attachment 308987 [details] [review]
android-bootstrap: Don't hide installation failure
Comment 4 Nicolas Dufresne (ndufresne) 2015-08-10 02:23:15 UTC 
Created attachment 308988 [details] [review]
android: Update to NDK r10e
Comment 5 Nicolas Dufresne (ndufresne) 2015-08-10 02:23:19 UTC 
Created attachment 308989 [details] [review]
android: Import definition of HOST_SED

HOST_SED definition is gone in r10e but sed is still prebuilt, so
import it's definition in our own makefile.
Comment 6 Nicolas Dufresne (ndufresne) 2015-08-10 02:24:04 UTC 
Note that after merging that, the bootstrap will need to be re-run on the build bot.
Comment 7 Sebastian Dröge (slomo) 2015-08-10 08:42:50 UTC 
Comment on attachment 308988 [details] [review]
android: Update to NDK r10e

Make sure to poke Edward before pushing this so the CI doesn't collapse :)
Comment 8 Nicolas Dufresne (ndufresne) 2015-08-14 09:57:48 UTC 
Attachment 308987 [details] pushed as 3aae1a1 - android-bootstrap: Don't hide installation failure
Attachment 308988 [details] pushed as 261d1f2 - android: Update to NDK r10e
Attachment 308989 [details] pushed as c449183 - android: Import definition of HOST_SED
Comment 9 Nicolas Dufresne (ndufresne) 2015-08-14 10:03:50 UTC 
For the reference, Edward informed me the the build bot was updating the bootstrap automatically.