After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750141 - The alt key get's passed to Xwayland apps while alt-tabbing
The alt key get's passed to Xwayland apps while alt-tabbing
Status: RESOLVED NOTGNOME
Product: mutter
Classification: Core
Component: wayland
3.17.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 755804 758347 (view as bug list)
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2015-05-30 11:45 UTC by Juraj Fiala
Modified: 2016-12-15 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Juraj Fiala 2015-05-30 11:45:26 UTC
Easy to reproduce. Login to "GNOME on Wayland", open Firefox, alt-tab, and Firefox will show it's alt-menu.

GNOME 3.16.2, Arch Linux, fully updated.

Thanks.
Comment 1 Juraj Fiala 2015-05-30 12:52:42 UTC
Also, this occurs only if the alt-tab window switcher displays. If it's just a quick alt-tab, so that the switcher won't open, it doesn't occur.
Comment 2 Juraj Fiala 2015-08-24 09:05:20 UTC
Still happens on 3.17.90, except that the Alt key get's passed ALWAYS, even on a quick Alt-Tab.
Comment 3 Daniel Stone 2015-09-16 08:32:22 UTC
Need to revive my Xwayland patches to fix this.
Comment 4 Christian Stadelmann 2015-11-15 19:12:18 UTC
I doubt this issue is specific to wayland, it has been present on X11 (gnome-shell 3.16.x) too. And I doubt this can ever be fixed because it will break all mnemonics (those underlined letters in menus).

Comment #2 doesn't apply to my installation (Fedora 23, gnome 3.18.2).
Comment 5 Daniel Stone 2015-11-17 15:51:26 UTC
(In reply to Christian Stadelmann from comment #4)
> I doubt this issue is specific to wayland, it has been present on X11
> (gnome-shell 3.16.x) too. And I doubt this can ever be fixed because it will
> break all mnemonics (those underlined letters in menus).

In the XWayland case, it's because we send real press/release events rather than letting them be handled by KeymapNotify.
Comment 6 Rui Matos 2015-11-20 14:26:14 UTC
*** Bug 758347 has been marked as a duplicate of this bug. ***
Comment 7 boloomka 2015-11-20 15:01:29 UTC
(In reply to Christian Stadelmann from comment #4)
> I doubt this issue is specific to wayland, it has been present on X11
> (gnome-shell 3.16.x) too. And I doubt this can ever be fixed because it will
> break all mnemonics (those underlined letters in menus).

It doesn't occur in X11, at least with Firefox. On X11, when you press Alt, you can still use mnemonics (you can for example press Alt-f for "File"), but menu bar doesn't show until you *release* Alt. So using Alt-Tab on X11 doesn't result in menu bar in Firefox appearing and then disappearing quickly. It does on Wayland - see this: https://bug758347.bugzilla-attachments.gnome.org/attachment.cgi?id=315895
Comment 8 Christian Stadelmann 2015-11-20 15:34:41 UTC
(In reply to boloomka from comment #7)
> It doesn't occur in X11, at least with Firefox. On X11, when you press Alt,
> you can still use mnemonics (you can for example press Alt-f for "File"),
> but menu bar doesn't show until you *release* Alt. So using Alt-Tab on X11
> doesn't result in menu bar in Firefox appearing and then disappearing
> quickly. It does on Wayland - see this:
> https://bug758347.bugzilla-attachments.gnome.org/attachment.cgi?id=315895

What I see in your video (what you describe is happening on wayland) is what happens for me on X11.
On wayland the menu bar just stays visible. Otherwise it is the same as X11.
Comment 9 Daniel Stone 2015-11-20 15:39:45 UTC
http://lists.freedesktop.org/archives/xorg-devel/2015-November/047979.html should resolve this.
Comment 10 Daniel Stone 2015-11-25 12:25:30 UTC
Patches merged into XWayland master; this should now be no more broken than X11 ever was.
Comment 11 Juraj Fiala 2016-03-23 17:39:41 UTC
Hm, still a problem, do you know if the fix got to release?
Comment 12 Christian Stadelmann 2016-03-23 18:38:40 UTC
(In reply to Juraj Fiala from comment #11)
> Hm, still a problem, do you know if the fix got to release?

No, it was merged into XWayland master after 1.18.x (or its dev version) was branched from XWayland master. With no further changes we have to wait for xorg-x11-server 1.19.x, which is not yet released. Don't expect it soon.

I don't know what Fedora's strategy will be here:
1. stick to an old xserver (especially in terms of xwayland)
2. backport some fixes (high maintenance burden)
3. ship a tested xserver git snapshot (very risky)
Looks like updates to 1.18.2 give us sufficiently hard times so I guess it will be 1).

XWayland upstream changes can be seen here: 
for 1.18.x: https://cgit.freedesktop.org/xorg/xserver/log/hw/xwayland?h=server-1.18-branch
for master: https://cgit.freedesktop.org/xorg/xserver/log/hw/xwayland
Comment 13 Rui Matos 2016-07-14 12:53:35 UTC
I believe this is fixed?
Comment 14 Christian Stadelmann 2016-07-14 13:12:02 UTC
(In reply to Rui Matos from comment #13)
> I believe this is fixed?

I don't know. Did you test upstream (to become 1.19.x xorg-x11-server) master branch? I didn't and I'd prefer to leave it open until it lands in any stable distro release.
Comment 15 Adrien Bustany 2016-11-28 09:31:38 UTC
So Fedora 25 ships with xorg-x11-server-Xwayland-1.19.0-1.fc25.x86_64, and I still observe the following behaviour:

- Pressing and releasing alt shows the menu - OK
- Doing a "quick" alt tab (switcher doesn't show) doesn't show the menu - OK
- Doing a "full" alt tab (switcher shows) shows the menu - NOK

What that means is that if I do a "full" alt tab and come back to firefox, and then press eg. "f", the file menu opens. I'd argue this is a rather minor issue, but it's still present. I'm therefore resetting the status to "NEW".
Comment 16 Rui Matos 2016-11-28 12:41:44 UTC
Daniel's patches fixed the key press side of this but there was still an issue for key releases. I submitted a patch for that https://patchwork.freedesktop.org/patch/123758/ . In any case, not a mutter bug.
Comment 17 Adrien Bustany 2016-11-28 12:46:45 UTC
OK, good to know that there's a patch for that issue, thanks for the update! Do you know if there's a chance for this patch to make it in a "point" release, ie. a minor one that would have a chance to end up in Fedora 25 (or in other distros shipping 1.19.x), or is it material for a later major release?
Comment 18 Olivier Fourdan 2016-11-30 07:43:03 UTC
*** Bug 755804 has been marked as a duplicate of this bug. ***
Comment 19 Mosaab Alzoubi 2016-12-15 12:39:03 UTC
Tried the patch, Doesn't fix this bug :(
Comment 20 Mosaab Alzoubi 2016-12-15 12:39:23 UTC
Fedora 25, Firefox 50