After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750135 - Stop using gnome-common - it is deprecated
Stop using gnome-common - it is deprecated
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-30 08:15 UTC by Robert Ancell
Modified: 2015-06-01 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Stop using gnome-common as specified in https://wiki.gnome.org/Projects/GnomeCommon/Migration (2.29 KB, patch)
2015-05-30 08:17 UTC, Robert Ancell
none Details | Review
Stop using gnome-common as specified in https://wiki.gnome.org/Projects/GnomeCommon/Migration (2.62 KB, patch)
2015-05-30 21:29 UTC, Robert Ancell
committed Details | Review

Description Robert Ancell 2015-05-30 08:15:25 UTC
According to [1] gnome-common is deprecated. Patch attached follows the recommendations for replacing it.

[1] https://wiki.gnome.org/Projects/GnomeCommon/Migration
Comment 1 Robert Ancell 2015-05-30 08:17:01 UTC
Created attachment 304301 [details] [review]
Stop using gnome-common as specified in https://wiki.gnome.org/Projects/GnomeCommon/Migration
Comment 2 Michael Catanzaro 2015-05-30 13:11:56 UTC
Review of attachment 304301 [details] [review]:

"accepted-commit_now" so we don't forget this, but let's wait a couple days for a response to https://mail.gnome.org/archives/desktop-devel-list/2015-May/msg00050.html
Comment 3 Michael Catanzaro 2015-05-30 13:27:27 UTC
Review of attachment 304301 [details] [review]:

Ah, we also need to remove GNOME_MAINTAINER_MODE_DEFINES from configure.ac.
Comment 4 Robert Ancell 2015-05-30 21:29:19 UTC
Created attachment 304315 [details] [review]
Stop using gnome-common as specified in https://wiki.gnome.org/Projects/GnomeCommon/Migration

Removed GNOME_MAINTAINER_MODE_DEFINES
Comment 5 Michael Catanzaro 2015-06-01 12:22:28 UTC
Pushed with set +-x tweaks (added to the wiki page), thanks!

Attachment 304315 [details] pushed as b1d71b1 - Stop using gnome-common as specified in https://wiki.gnome.org/Projects/GnomeCommon/Migration