GNOME Bugzilla – Bug 750111
rtsp-media: emit signal for preparing dynamic payloads
Last modified: 2018-11-03 15:38:42 UTC
Created attachment 304268 [details] [review] patch When using dynamic payloads, it is useful to know when rtsp-media has connected to the pad-added signal, so that the application code can continue to add those pads. If the dynpay element is a decodebin, the pads are always added after the element changes state to PAUSED, which is set after connecting the pad-added signal internally and therefore it works fine. However, there can be other cases where the application needs to add the pads externally and therefore it needs to know when is the right moment to do so. This patch adds a "preparing" signal that is emitted at the end of start_prepare, and compliments the "prepared" and "unprepared" signals.
Any thoughts on this?
Review of attachment 304268 [details] [review]: ::: gst/rtsp-server/rtsp-media.h @@ +158,3 @@ void (*removed_stream) (GstRTSPMedia *media, GstRTSPStream * stream); + void (*preparing) (GstRTSPMedia *media); This breaks ABI, has to go at the very end and remove some padding
Created attachment 346559 [details] [review] rtsp-media: emit signal for preparing dynamic payloads Here is a fixed (wrt ABI issues) version of the patch, which applies on top of latest master.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/issues/11.