GNOME Bugzilla – Bug 750105
Migrating 2.8 theme to 2.9/2.10
Last modified: 2016-03-29 15:30:03 UTC
As the themes from Gimp 2.8 do not work with Gimp 2.9 there should be: a) A automatic migration from old to new themes. b) If this is to much work write a migration guide that documents the changes. c) Disable old 2.8 themes in 2.9. A good example is this theme: https://alexskc.wordpress.com/2015/05/09/gimp-hidpi-symbolic-icon-theme/
a) not going to happen, we'd have to parse an arbitrary gtkrc b) yes c) same problem as a), how are we going to detect "old themes"?
a) OK b) Fine, this is really missing c) At least by not coping themes from the .gimp2.8 to the .gimp-2.9/10 directory
I think it makes sense to not copy themes from 2.8. After all, it seems any 2.8 themes will be broken by design in 2.10. So we should just skip them and output a warning when we discover custom themes to tell the user that it is normal if themes are "lost" during migration, and that one should get new themes made specifically for GIMP 2.10. If you want, I can implement this in the migration code, Mitch.
Yes please, it should be a one-liner that skips that folder.
commit ea13e816abb52111bc5f8a858f6ba7d5d2afb03f Author: Jehan <jehan@girinstud.io> Date: Tue Jan 19 22:36:27 2016 +0100 Bug 750105 - Migrating 2.8 themes to 2.9/2.10 Old themes should not be copied over to the GIMP 2.9/2.10 config at first launch since they won't be compatible anyway. Let's go the less painful way by dropping old themes rather than trying to salvage themes which we know will be broken by design. We still need a migration guide so I let this report opened for now, I guess.
Draekko and Klaus > if you ever feel bored, you are welcome to participate to the creation of a migration guide about how to create a GIMP 2.10 theme and icon theme, which we will be able to publish on gimp.org.
Adding patdavid in the loop. Patdavid > it would be cool if you could think of a place on the website where to publish a theme migration (from 2.8 to 2.10), or simply theme creation tutorial.
We can include a section on the "Tutorials" page for "Theming" no problem! Just get me the content. :) The posts are normally written in Markdown, but I can accept whatever you have and port it as needed. If you want to be helpful and write in Markdown first, there's a quick reference: https://www.gimp.org/about/meta/markdown.html And/or just follow a previously published tutorials as a reference. Feel free to hit me up with questions.
I can write a tutorial about making gimp-icon themes someday. It has low priority in my to-do list. First bug 759904 has to be closed, second the gimp-color-icon-theme, most icons there missing a svg so they have to be redrawn. Quick N'dirty tutorial: 1. we need the icons from this list. https://git.gnome.org/browse/gimp/tree/icons/Symbolic/icon-list.mk 2. paint everything as svg 3. paint everything in 16x16, which is quite a challenge ( e.g. have a look at the gnome adwaita icon theme. You will be astonished that many fullcolor icons are in 512x512 or 64x64, but much to many 16x16 are simple png's wrapped into svg and not real vector graphics).
A tutorial should also either explain the icon.theme file format, or at the very least point to a resource that does describe it, for example: http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
Sorry that should have read index.theme file
This commit pretty much "fixes" this bug, old themes are just gone. commit 59f4ee55c977fb4181265b67a9cb181bbd4fa7b8 Author: Jehan <jehan@girinstud.io> Date: Fri Mar 25 21:43:58 2016 +0100 app: do not migrate theme settings. Themes from 2.8 and before are not fully compatible with 2.10. In particular, embedded icons would not work and you would end up with the Symbolic icon theme (light colors), which may not work well with a custom theme. It is better to reset to the new defaults upon migration and users can still try and configure the theming afterwards if they wish.
I completely forgot this report existed. Anyway my commit does not migrate the settings, but the themes are still copied from 2.8 to 2.10. In other words, if you had a custom theme, it won't be selected anymore, but it stays installed and you will see it in the 2.10 preferences so you can test it (just in case because some themes could still work). If anyone thinks there are reasons for not migrating the theme at all, you can reopen and explain why.