After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750102 - Deadcode in totem-playlist.c
Deadcode in totem-playlist.c
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-29 12:28 UTC by Bastien Nocera
Modified: 2015-12-04 10:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
playlist: Remove dead code (1.56 KB, patch)
2015-12-04 10:27 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2015-05-29 12:28:21 UTC
totem-3.14.3/src/totem-playlist.c:964: effectively_constant: Local variable "ref" is assigned only once, to a constant value, making it effectively constant throughout its scope. If this is not the intent, examine the logic to see if there is a missing assignment that would make "ref" not remain constant.
#   962|   	/* And update current to point to the right file again */
#   963|   	if (ref != NULL) {
#   964|-> 		gtk_tree_path_free (playlist->priv->current);
#   965|   		playlist->priv->current = gtk_tree_row_reference_get_path (ref);
#   966|   		gtk_tree_row_reference_free (ref);
Comment 1 Bastien Nocera 2015-12-04 10:27:00 UTC
Created attachment 316756 [details] [review]
playlist: Remove dead code
Comment 2 Bastien Nocera 2015-12-04 10:46:13 UTC
Attachment 316756 [details] pushed as 7899b39 - playlist: Remove dead code