GNOME Bugzilla – Bug 750101
rtspsrc: send the user-agent header
Last modified: 2015-08-16 13:40:25 UTC
Created attachment 304244 [details] [review] proposed patch It is useful in certain cases for the server to know the user-agent of the client. This patch adds support in rtspsrc for sending that user-agent string. This string is modifiable by a "user-agent" property and defaults to "GStreamer/<version>" I noticed there is also bug 614558 related to this, but it's more of a discussion about all network elements in general. This report is specific to rtspsrc.
Created attachment 307419 [details] [review] rtspsrc: send the User-Agent header rebased on top of current master
Any comment about this?
Review of attachment 307419 [details] [review]: Looks good except: ::: gst/rtsp/gstrtspsrc.c @@ +4655,3 @@ + /* set user-agent */ + gst_rtsp_message_add_header (&request, GST_RTSP_HDR_USER_AGENT, + src->user_agent); This probably complains if src->user_agent == NULL
Created attachment 309276 [details] [review] rtspsrc: wrap gst_rtsp_message_init_request in a local function
Created attachment 309277 [details] [review] rtspsrc: send the User-Agent header
commit af03341e2600a4ad62543c97ce58001a9374a9d5 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Fri Aug 14 15:42:42 2015 +0200 rtspsrc: wrap gst_rtsp_message_init_request in a local function This will allow adding common request initialization, like the user agent string, in just one place. commit e2f2f087ecd475b9358451a5ca6d002f381da67c Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Fri Aug 14 15:46:53 2015 +0200 rtspsrc: send the User-Agent header Sometimes it is useful to know this information on the server side. Other popular implementations (vlc, ffmpeg, ...) also send this header on every message. This includes a new "user-agent" property that the user can set to use a custom User-Agent string. The default is "GStreamer/<version>" https://bugzilla.gnome.org/show_bug.cgi?id=750101