GNOME Bugzilla – Bug 750099
Remove unnecessary dependencies from client libs
Last modified: 2015-06-03 11:03:23 UTC
GVfs has a lot of low-level dependencies. We want to split gvfs package on client and daemon part due to app sandboxing: https://wiki.gnome.org/Projects/SandboxedApps We want to have only the client part of GVfs in the runtime and we don't want unnecessary dependencies there. Thus we need to remove e.g. libbluray and libudev dependencies from libgvfsdbus.
I've already removed libbluray dependency by the commit 95bf384.
Created attachment 304241 [details] [review] metadata: Get tree from udev via dbus
Review of attachment 304241 [details] [review]: Looks good otherwise ::: metadata/dbus-interface.xml @@ +41,3 @@ <arg type='ay' name='dest_path' direction='in'/> </method> + <method name="GetTreeFromUdev"> Don't use Udev in the name (its an implementation detail). GetTreeFromDevice. ::: metadata/metatree.c @@ +169,3 @@ + GVfsMetadata *proxy; + + G_LOCK (metadata_proxy); I think this should be a g_once_init() thing. If we fail to create a proxy we should never try again, as it will be a slow sync call.
Created attachment 304425 [details] [review] metadata: Get tree from udev via dbus So g_once is used in meta_tree_get_metadata_proxy now, method name is changed and it is also fixed the case, when the result is NULL.
Review of attachment 304425 [details] [review]: lgtm
Comment on attachment 304425 [details] [review] metadata: Get tree from udev via dbus commit b78cc85d2dda10e5488cf23cb63008ca339836dc