After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750089 - validate: media-check: add to print new line
validate: media-check: add to print new line
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
git master
Other Linux
: Normal minor
: 1.5.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-29 07:56 UTC by Wonchul Lee
Modified: 2015-06-14 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
validate: media-check: add to print new line (1.24 KB, patch)
2015-05-29 07:57 UTC, Wonchul Lee 		committed Details | Review

Description Wonchul Lee 2015-05-29 07:56:50 UTC 
I just add a new line character to make it easy to see the log message when fail to check media.
Comment 1 Wonchul Lee 2015-05-29 07:57:41 UTC 
Created attachment 304228 [details] [review]
validate: media-check: add to print new line
Comment 2 Thibault Saunier 2015-05-29 08:53:40 UTC 
Doesn't  gst_media_descriptor_writer_new_discover (runner, argv[1], full, TRUE,...); make a report when it fails?

It definitely should, and we should not need to add a print at that point as the MediaDescriptor (even if not return) should do the reporting itself.
Comment 3 Wonchul Lee 2015-05-29 14:10:27 UTC 
No, It makes a report when it fails with using gat-validate-launcher.

I tried to analyse failure test case with gst-validate-media-check-1.0, and command line became a little bit unclean state after print failure log due to missing newline character. So, I just add a tiny patch of it.
Comment 4 Wonchul Lee 2015-05-29 14:28:16 UTC 
Sorry.
Yes, It makes a report when it fails with using gat-validate-launcher. I can get a correct report from it.
Comment 5 Thibault Saunier 2015-06-09 08:25:10 UTC 
So should we just remove the printing?

I do not care tbh much :)
Comment 6 Tim-Philipp Müller 2015-06-14 21:48:42 UTC 
Patch is obviously correct, so let's get it in and get this closed, and if anyone feels like it should be removed they can still do so once they decide that's what should be done :)

 commit 9ea5df9c988a03de934902ed870866d4086c2fe5
 Author: Wonchul Lee <chul0812@gmail.com>
 Date:   Fri May 29 16:45:25 2015 +0900

    validate: media-check: add newline to end of print statements
    
    https://bugzilla.gnome.org/show_bug.cgi?id=750089