After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750026 - "-listen tcp" is needed for Xorg 1.17
"-listen tcp" is needed for Xorg 1.17
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2015-05-28 12:17 UTC by Mantas Mikulėnas (grawity)
Modified: 2015-11-10 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Check xorg version and use -listen if new enough (2.56 KB, patch)
2015-11-10 14:05 UTC, Nathaniel Roach
committed Details | Review

Description Mantas Mikulėnas (grawity) 2015-05-28 12:17:42 UTC
Starting with Xorg 1.17, TCP is off by default and a new "-listen" option has been added to explicitly re-enable it. (http://cgit.freedesktop.org/xorg/xserver/commit/?id=cc59be38b7eff52a1d003b390f2994c73ee0b3e9)

So gdm now has to pass "-listen tcp" if DisallowTCP=false is set in gdm/custom.conf. However, doing that would cause a fatal error with Xorg 1.16 or older, which did not have that option yet.

Fun.
Comment 1 Nathaniel Roach 2015-11-10 14:05:09 UTC
Created attachment 315189 [details] [review]
Check xorg version and use -listen if new enough
Comment 2 Ray Strode [halfline] 2015-11-10 14:33:09 UTC
Thanks, pushed with minor tweaks as commit 3f59fa0da5168451898db63e51e312ce894af0c1 .