After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749920 - gegl_node_get_producer should take a const gchar *pad_name
gegl_node_get_producer should take a const gchar *pad_name
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-05-26 17:38 UTC by Debarshi Ray
Modified: 2015-05-26 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GeglNode: gegl_node_get_producer should take a const gchar *pad_name (1.53 KB, patch)
2015-05-26 17:40 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-05-26 17:38:02 UTC 
I can't imagine why gegl_node_get_producer would want to own or change the pad_name parameter. It should be const gchar *, not gchar *.

Let's fix it so that applications don't have to do a bunch of casts to make the compiler shut up.
Comment 1 Debarshi Ray 2015-05-26 17:40:47 UTC 
Created attachment 304033 [details] [review]
GeglNode: gegl_node_get_producer should take a const gchar *pad_name
Comment 2 Debarshi Ray 2015-05-26 20:37:57 UTC 
From #gegl on GIMPNet:
<pippin> rishi: please push