After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749916 - videocrop: Make videocrop controllable
videocrop: Make videocrop controllable
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 740502
Blocks:
 
 
Reported: 2015-05-26 16:24 UTC by Lazar Claudiu
Modified: 2018-11-03 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make videocrop controllable (2.24 KB, patch)
2015-05-26 16:24 UTC, Lazar Claudiu 		needs-work Details | Review
Usage example (3.55 KB, text/x-csrc)
2015-05-27 05:08 UTC, Lazar Claudiu 		  Details

Description Lazar Claudiu 2015-05-26 16:24:07 UTC 
Useful for video effect
Comment 1 Lazar Claudiu 2015-05-26 16:24:34 UTC 
Created attachment 304029 [details] [review]
Make videocrop controllable
Comment 2 Nicolas Dufresne (ndufresne) 2015-05-26 16:28:04 UTC 
Review of attachment 304029 [details] [review]:

Please, provide a unit test. I have doubt that the locking is all correct, though maybe when using a controller makes the changes atomic somehow (I don't know the internal of the controller code).
Comment 3 Nicolas Dufresne (ndufresne) 2015-05-26 16:40:19 UTC 
Review of attachment 304029 [details] [review]:

::: gst/videocrop/gstvideocrop.c
@@ +414,3 @@
 
+  gst_object_sync_values (GST_OBJECT (vfilter),
+      GST_BUFFER_TIMESTAMP (in_frame->buffer));

I believe that renegotiation will only take place on the next frame (all we do is set a flag on the pad), which would mean you have a delay of 1 frame here.
Comment 4 Lazar Claudiu 2015-05-27 05:08:23 UTC 
Created attachment 304048 [details]
Usage example
Comment 5 GStreamer system administrator 2018-11-03 15:00:29 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/187.