GNOME Bugzilla – Bug 749914
Boxes can't compile
Last modified: 2016-09-20 08:15:55 UTC
GTK+'s VAPI changed and broke the compilation of Boxes.
Created attachment 304027 [details] [review] build: Bump vala dep to 0.28.0.16 A more recent version of Vala is required as a change in GTK+'s VAPI broke the compilation of collection-view.vala.
Review of attachment 304027 [details] [review]: * The actual change should be in separate patch. * We need to be a bit more specific here. What changed and where exactly.
Review of attachment 304027 [details] [review]: Oh and big nitpick: Please refer to classes rather than filenames.
Created attachment 304049 [details] [review] build: Bump vala dep to 0.28.0.16 A more recent version of Vala is required as GTK+'s VAPI changed to turn Gtk.Popover.pointing_to from Cairo.RectangleInt to Gdk.Rectangle, breaking the compilation of CollectionView when setting ActionsPopover.pointing_to.
Created attachment 304050 [details] [review] collection-view: Reflect GTK+ VAPI changes Assign a Gdk.Rectangle instead of a Cairo.RectangleInt to context_popover.pointing_to in method launch_context_popover_for_path() in order to reflect changes in GTK+'s VAPI.
Review of attachment 304050 [details] [review]: Just on minor nitpick. I'd write "Gtk.Popover.pointing_to" instead of "context_popover.pointing_to" so its readily obvious what you are talking about, without looking at the code. I'll fix that when merging..
Pushed with minor changes to commit log. Thanks Attachment 304049 [details] pushed as 1feb0e6 - build: Require Vala >= 0.28.0.16 Attachment 304050 [details] pushed as 2a804f5 - collection-view: Reflect GTK+ VAPI changes