After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749914 - Boxes can't compile
Boxes can't compile
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-05-26 15:28 UTC by Adrien Plazas
Modified: 2016-09-20 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: Bump vala dep to 0.28.0.16 (1.61 KB, patch)
2015-05-26 15:28 UTC, Adrien Plazas
needs-work Details | Review
build: Bump vala dep to 0.28.0.16 (863 bytes, patch)
2015-05-27 06:15 UTC, Adrien Plazas
committed Details | Review
collection-view: Reflect GTK+ VAPI changes (1.35 KB, patch)
2015-05-27 06:15 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2015-05-26 15:28:01 UTC
GTK+'s VAPI changed and broke the compilation of Boxes.
Comment 1 Adrien Plazas 2015-05-26 15:28:58 UTC
Created attachment 304027 [details] [review]
build: Bump vala dep to 0.28.0.16

A more recent version of Vala is required as a change in GTK+'s VAPI
broke the compilation of collection-view.vala.
Comment 2 Zeeshan Ali 2015-05-26 15:55:06 UTC
Review of attachment 304027 [details] [review]:

* The actual change should be in separate patch.

* We need to be a bit more specific here. What changed and where exactly.
Comment 3 Zeeshan Ali 2015-05-26 15:55:54 UTC
Review of attachment 304027 [details] [review]:

Oh and big nitpick: Please refer to classes rather than filenames.
Comment 4 Adrien Plazas 2015-05-27 06:15:49 UTC
Created attachment 304049 [details] [review]
build: Bump vala dep to 0.28.0.16

A more recent version of Vala is required as GTK+'s VAPI changed to turn
Gtk.Popover.pointing_to from Cairo.RectangleInt to Gdk.Rectangle,
breaking the compilation of CollectionView when setting
ActionsPopover.pointing_to.
Comment 5 Adrien Plazas 2015-05-27 06:15:55 UTC
Created attachment 304050 [details] [review]
collection-view: Reflect GTK+ VAPI changes

Assign a Gdk.Rectangle instead of a Cairo.RectangleInt to
context_popover.pointing_to in method launch_context_popover_for_path()
in order to reflect changes in GTK+'s VAPI.
Comment 6 Zeeshan Ali 2015-05-27 16:46:40 UTC
Review of attachment 304050 [details] [review]:

Just on minor nitpick. I'd write "Gtk.Popover.pointing_to" instead of "context_popover.pointing_to" so its readily obvious what you are talking about, without looking at the code. I'll fix that when merging..
Comment 7 Zeeshan Ali 2015-05-27 22:55:41 UTC
Pushed with minor changes to commit log. Thanks

Attachment 304049 [details] pushed as 1feb0e6 - build: Require Vala >= 0.28.0.16
Attachment 304050 [details] pushed as 2a804f5 - collection-view: Reflect GTK+ VAPI changes