After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749909 - matroska: overwritten value assignment
matroska: overwritten value assignment
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal minor
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2015-05-26 14:46 UTC by Luis de Bethencourt
Modified: 2015-05-27 15:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch removing first assignment (889 bytes, patch)
2015-05-26 14:46 UTC, Luis de Bethencourt
committed Details | Review

Description Luis de Bethencourt 2015-05-26 14:46:29 UTC
Created attachment 304018 [details] [review]
patch removing first assignment

The value curpos in gst/matroska/matroska-read-common.c:2419 is set to gst_ebml_read_get_pos (ebml) and then immediately after set again to the same value. The first assignment being overwritten with the same value.

  guint64 curpos;

  curpos = gst_ebml_read_get_pos (ebml);

  /* Make sure we don't parse a tags element twice and
   * post it's tags twice */
  curpos = gst_ebml_read_get_pos (ebml);

This looks like a simple dead assignment problem. But want to confirm here in bugzilla since this code has been in gst-plugins-good since 2011, making me wonder if there is something hidden I am missing.
Comment 1 Luis de Bethencourt 2015-05-27 15:58:13 UTC
Review of attachment 304018 [details] [review]:

Either nobody has any complaints or people are too busy for reviews.

Won't bother peeps with this and will remove it from the Open queue.

Merged: commit 6d06a74f7f0386a912362ed3caacc287b16412cb