GNOME Bugzilla – Bug 749900
Collections in "collections dialog" aren't displayed
Last modified: 2015-10-15 14:53:21 UTC
steps to reproduce: 1. select one or more objects 2. click "Add to collection" Result: no collections displayed Expected result: my collections displayed
Created attachment 304004 [details] [review] query: Display collections in "collection dialog" Fallout from 17322bb4b627ebfef0b8c36ba22d390d0910faa6
Review of attachment 304004 [details] [review]: Thanks for tracking this down, Alessandro. ::: src/query.js @@ +226,2 @@ else + collectionsIdentifier = LOCAL_COLLECTIONS_IDENTIFIER; We don't need the if condition and the collectionsIdentifier variable anymore. Just directly use LOCAL_COLLECTIONS_IDENTIFIER in the statement below. As it used to be before commit 17322bb4b627ebfef0b8c36ba22d390d0910faa6
Created attachment 304010 [details] [review] query: Display collections in "collection dialog" Fallout from 17322bb4b627ebfef0b8c36ba22d390d0910faa6
Created attachment 304011 [details] [review] query: Display collections in "collection dialog" Fallout from 17322bb4b627ebfef0b8c36ba22d390d0910faa6
Review of attachment 304011 [details] [review]: Perfect, thanks.
Attachment 304011 [details] pushed as 5e9d776 - query: Display collections in "collection dialog"
[master] pushed as 5e9d776 - query: Display collections in "collection dialog" [gnome-3-16] pushed as 78b56af - query: Display collections in "collection dialog"
The patch introduces a regression: before there were different collections for Books and Documents ('gb:collection:local:' vs 'gd:collection:local:') now we have the same collections in both (only 'gd:collection:local:').
Created attachment 313255 [details] [review] selections, query: Different collections for Books and Documents
Review of attachment 313255 [details] [review]: Oh, dear. What was I thinking when reviewing the earlier patch? Anyway, this looks correct to me, but I would like to have some more text in the commit message that makes it clear that the earlier patch was an utter mistake.
Created attachment 313376 [details] [review] selections, query: Different collections for Books and Documents Restore separate collections for Books and Documents, and fix the queries accordingly. This reverts 5e9d776ae276cb660104bb19d8d4743c5f2f6747
Review of attachment 313376 [details] [review]: Thanks. Pushed to master, gnome-3-18 and gnome-3-16.